fix(doctor): check global agent-browser when local install not found#19671
Merged
Conversation
When agent-browser is globally installed via 'npm install -g agent-browser'
but not present in the local node_modules, doctor falsely warns that it's
not installed. Add shutil.which('agent-browser') as a fallback check after
the local path check.
Closes #15951
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #16125 by @ms-alan onto current main.
Summary
When
agent-browseris installed globally vianpm install -g agent-browserbut not present in the localnode_modules,hermes doctorfalsely warned that it wasn't installed. Checkshutil.which("agent-browser")as a fallback after the local install check.Note on authorship
The contributor's original commit was authored with an empty email (
pander <>) due to a local git-config quirk. Re-attributed toms-alan <chenb19870707@gmail.com>(the PR opener's public GitHub email) during salvage so the commit passes AUTHOR_MAP validation.Changes
Validation
Manual review; surgical fallback check.
Original PR: #16125
Fixes: #15951