test(doctor): add regression for kimi-coding-cn provider validation#19734
Merged
Conversation
- Rebased on upstream/main to resolve conflicts - Added test_run_doctor_accepts_kimi_coding_cn_provider test - All 30 tests pass
alt-glitch
added
type/test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #15583 by @VinVC onto current main.
Summary
Regression test covering
hermes doctorvalidation of thekimi-coding-cnfirst-class Hermes provider ID. The underlying fix (letting exact Hermes provider IDs bypass the models.dev alias table) was independently applied to main after this PR opened — this preserves the test coverage so future regressions are caught.Conflict resolution during salvage
Test file picked up a separate test block from main; preserved both side-by-side.
Changes
test_run_doctor_accepts_kimi_coding_cn_provider(+40/-0)Validation
scripts/run_tests.sh tests/hermes_cli/test_doctor.py -k kimi_coding_cn -> 1 passed
Original PR: #15583