Skip to content

fix(kanban): filter dashboard board by selected tenant#19817

Closed
maciekczech wants to merge 2 commits into
NousResearch:mainfrom
maciekczech:kanban-dashboard-select-filter-regression
Closed

fix(kanban): filter dashboard board by selected tenant#19817
maciekczech wants to merge 2 commits into
NousResearch:mainfrom
maciekczech:kanban-dashboard-select-filter-regression

Conversation

@maciekczech
Copy link
Copy Markdown

@maciekczech maciekczech commented May 4, 2026

Summary

  • Fixes Kanban dashboard client-side filtering so the rendered board respects the selected tenant, not only assignee/search filters.
  • Keeps the existing dashboard Select wiring through onValueChange/fallback handler.
  • Adds regression coverage for both the Select handler wiring and tenant-aware client-side filtering.

Implementation note

plugins/kanban/dashboard/dist/index.js looks like a generated bundle, but for current Hermes dashboard plugins it is the committed runtime entry referenced by dashboard/manifest.json. This plugin currently has no checked-in src/, package.json, Vite/Rollup/esbuild config, or other source/build input under plugins/kanban/dashboard/; the tracked plugin files are only dist/index.js, dist/style.css, manifest.json, and plugin_api.py.

Why

The board API can fetch tenant-scoped data, but the dashboard also filters a cached board locally for search/assignee interactions. Without applying tenantFilter in filteredBoard and including it in the memo dependencies, tenant switches can leave stale/non-tenant cards visible until a full reload catches up.

Test Plan

  • node --check plugins/kanban/dashboard/dist/index.js
  • env -u HERMES_KANBAN_TASK -u HERMES_KANBAN_DB -u HERMES_KANBAN_WORKSPACE -u HERMES_KANBAN_WORKSPACES_ROOT scripts/run_tests.sh tests/plugins/test_kanban_dashboard_plugin.py -q
  • Result: 45 passed, 4 warnings

@alt-glitch alt-glitch added type/test Test coverage or test infrastructure P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins labels May 4, 2026
@maciekczech maciekczech changed the title test(kanban): cover dashboard select filter wiring fix(kanban): filter dashboard board by selected tenant May 4, 2026
@alt-glitch alt-glitch added type/bug Something isn't working and removed type/test Test coverage or test infrastructure labels May 4, 2026
@teknium1
Copy link
Copy Markdown
Contributor

teknium1 commented May 7, 2026

Merged via #21349 — both your commits cherry-picked onto current main with authorship preserved via rebase-merge. Live-verified the tenant dropdown actually filters rendered cards now (3 tasks × 2 tenants, all three selector states behave correctly). Thanks @maciekczech!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants