fix(kanban): filter dashboard board by selected tenant#19817
Closed
maciekczech wants to merge 2 commits into
Closed
fix(kanban): filter dashboard board by selected tenant#19817maciekczech wants to merge 2 commits into
maciekczech wants to merge 2 commits into
Conversation
1 task
Contributor
|
Merged via #21349 — both your commits cherry-picked onto current main with authorship preserved via rebase-merge. Live-verified the tenant dropdown actually filters rendered cards now (3 tasks × 2 tenants, all three selector states behave correctly). Thanks @maciekczech! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selectwiring throughonValueChange/fallback handler.Implementation note
plugins/kanban/dashboard/dist/index.jslooks like a generated bundle, but for current Hermes dashboard plugins it is the committed runtime entry referenced bydashboard/manifest.json. This plugin currently has no checked-insrc/,package.json, Vite/Rollup/esbuild config, or other source/build input underplugins/kanban/dashboard/; the tracked plugin files are onlydist/index.js,dist/style.css,manifest.json, andplugin_api.py.Why
The board API can fetch tenant-scoped data, but the dashboard also filters a cached board locally for search/assignee interactions. Without applying
tenantFilterinfilteredBoardand including it in the memo dependencies, tenant switches can leave stale/non-tenant cards visible until a full reload catches up.Test Plan
node --check plugins/kanban/dashboard/dist/index.jsenv -u HERMES_KANBAN_TASK -u HERMES_KANBAN_DB -u HERMES_KANBAN_WORKSPACE -u HERMES_KANBAN_WORKSPACES_ROOT scripts/run_tests.sh tests/plugins/test_kanban_dashboard_plugin.py -q45 passed, 4 warnings