fix(kanban): preserve dashboard completion summaries#20016
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Merged via PR #20195 (commit 354502e). Your commit was cherry-picked onto current main with your authorship preserved in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20008
Summary
complete_taskinstead of dropping themhermes kanban edit <task_id> --result ...to backfill completed task results and update the latest completed run summary for audit/context recoveryScope
This stays inside the Kanban dashboard/API/CLI result path. It does not change dispatcher claim semantics or task completion rules outside already-supported Done transitions.
Verification
scripts/run_tests.sh tests/plugins/test_kanban_dashboard_plugin.py::test_bulk_status_done_forwards_completion_summary tests/plugins/test_kanban_dashboard_plugin.py::test_dashboard_done_actions_prompt_for_completion_summary tests/hermes_cli/test_kanban_core_functionality.py::test_cli_edit_backfills_result_on_done_task tests/hermes_cli/test_kanban_core_functionality.py::test_cli_edit_rejects_non_done_task-> 4 passedenv -u WEIXIN_TOKEN -u WEIXIN_ACCOUNT_ID -u WEIXIN_HOME_CHANNEL -u WEIXIN_HOME_CHANNEL_NAME -u WEIXIN_HOME_CHANNEL_THREAD_ID scripts/run_tests.sh tests/plugins/test_kanban_dashboard_plugin.py tests/hermes_cli/test_kanban_core_functionality.py::test_cli_complete_with_summary_and_metadata tests/hermes_cli/test_kanban_core_functionality.py::test_cli_edit_backfills_result_on_done_task tests/hermes_cli/test_kanban_core_functionality.py::test_cli_edit_rejects_non_done_task tests/hermes_cli/test_kanban_core_functionality.py::test_cli_bulk_complete_with_summary_rejects tests/hermes_cli/test_kanban_core_functionality.py::test_cli_bulk_complete_without_summary_still_works tests/hermes_cli/test_kanban_core_functionality.py::test_completed_event_payload_carries_summary-> 61 passedpython -m py_compile hermes_cli/kanban.py hermes_cli/kanban_db.py plugins/kanban/dashboard/plugin_api.pygit diff --check