fix(kanban): detect darwin zombie workers#20023
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20015
Summary
_pid_alive()zombie detection to macOS/Darwin usingps -o stat=afterkill(pid, 0)succeedsZas dead so crash detection can reclaim defunct workers promptly/proc/<pid>/statuspath unchangedScope
This is limited to Kanban dispatcher worker liveness checks. It does not change gateway scoped locks or process spawning semantics.
Verification
scripts/run_tests.sh tests/hermes_cli/test_kanban_core_functionality.py::test_pid_alive_helper tests/hermes_cli/test_kanban_core_functionality.py::test_pid_alive_detects_darwin_zombie tests/hermes_cli/test_kanban_core_functionality.py::test_detect_crashed_workers_reclaims-> 3 passedgit diff --check