Skip to content

fix(kanban): ignore stale current board pointers#20063

Closed
steezkelly wants to merge 1 commit into
NousResearch:mainfrom
steezkelly:fix/kanban-stale-current-board
Closed

fix(kanban): ignore stale current board pointers#20063
steezkelly wants to merge 1 commit into
NousResearch:mainfrom
steezkelly:fix/kanban-stale-current-board

Conversation

@steezkelly
Copy link
Copy Markdown
Contributor

Summary

  • Ignore stale <root>/kanban/current board pointers when resolving the active board
  • Fall back to default instead of treating a missing board slug as active
  • Add regression coverage so read/list flows do not synthesize a missing board from a stale pointer

Fixes #20055

Test Plan

  • venv/bin/python -m pytest tests/hermes_cli/test_kanban_boards.py::TestCurrentBoard::test_stale_file_pointer_falls_back_to_default -q -o 'addopts='
  • venv/bin/python -m pytest tests/hermes_cli/test_kanban_boards.py -q -o 'addopts='
  • venv/bin/python -m pytest tests/hermes_cli/test_kanban_db.py tests/hermes_cli/test_kanban_cli.py tests/hermes_cli/test_kanban_core_functionality.py tests/tools/test_kanban_tools.py tests/plugins/test_kanban_dashboard_plugin.py -q -o 'addopts='
  • venv/bin/python -m py_compile hermes_cli/kanban_db.py tests/hermes_cli/test_kanban_boards.py

@steezkelly
Copy link
Copy Markdown
Contributor Author

Local verification completed before opening this fork PR:

  • venv/bin/python -m pytest tests/hermes_cli/test_kanban_boards.py::TestCurrentBoard::test_stale_file_pointer_falls_back_to_default -q -o 'addopts=' → 1 passed
  • venv/bin/python -m pytest tests/hermes_cli/test_kanban_boards.py -q -o 'addopts=' → 50 passed
  • venv/bin/python -m pytest tests/hermes_cli/test_kanban_db.py tests/hermes_cli/test_kanban_cli.py tests/hermes_cli/test_kanban_core_functionality.py tests/tools/test_kanban_tools.py tests/plugins/test_kanban_dashboard_plugin.py -q -o 'addopts=' → 282 passed, 2 unrelated deprecation warnings
  • venv/bin/python -m py_compile hermes_cli/kanban_db.py tests/hermes_cli/test_kanban_boards.py → passed

GitHub Actions are currently showing action_required for this fork PR, so CI appears to be waiting for maintainer approval rather than failing on code.

@teknium1
Copy link
Copy Markdown
Contributor

teknium1 commented May 5, 2026

Merged via PR #20183 (commit d472d69). Your commit was cherry-picked onto current main with your authorship preserved in git log. Also added a stevekelly622@gmail.com → @steezkelly AUTHOR_MAP entry so CI's author-attribution check resolves cleanly for this and future contributions. Thanks — solid E2E-verified repro in the issue and a tight, minimal fix.

#20183

@teknium1 teknium1 closed this May 5, 2026
@steezkelly steezkelly deleted the fix/kanban-stale-current-board branch May 5, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kanban should not silently synthesize/create boards from a stale current-board pointer

3 participants