fix(kanban): ignore stale current board pointers#20063
Closed
steezkelly wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Local verification completed before opening this fork PR:
GitHub Actions are currently showing |
Contributor
|
Merged via PR #20183 (commit d472d69). Your commit was cherry-picked onto current main with your authorship preserved in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<root>/kanban/currentboard pointers when resolving the active boarddefaultinstead of treating a missing board slug as activeFixes #20055
Test Plan
venv/bin/python -m pytest tests/hermes_cli/test_kanban_boards.py::TestCurrentBoard::test_stale_file_pointer_falls_back_to_default -q -o 'addopts='venv/bin/python -m pytest tests/hermes_cli/test_kanban_boards.py -q -o 'addopts='venv/bin/python -m pytest tests/hermes_cli/test_kanban_db.py tests/hermes_cli/test_kanban_cli.py tests/hermes_cli/test_kanban_core_functionality.py tests/tools/test_kanban_tools.py tests/plugins/test_kanban_dashboard_plugin.py -q -o 'addopts='venv/bin/python -m py_compile hermes_cli/kanban_db.py tests/hermes_cli/test_kanban_boards.py