Skip to content

fix(kanban): include default profile in on-disk assignees#20123

Closed
Interstellar-code wants to merge 1 commit into
NousResearch:mainfrom
Interstellar-code:fix/kanban-default-profile-ondisk
Closed

fix(kanban): include default profile in on-disk assignees#20123
Interstellar-code wants to merge 1 commit into
NousResearch:mainfrom
Interstellar-code:fix/kanban-default-profile-ondisk

Conversation

@Interstellar-code
Copy link
Copy Markdown
Contributor

Summary

  • treat the implicit default profile as on-disk in Kanban assignee/profile enumeration
  • keep named-profile discovery under <default-root>/profiles/<name>/config.yaml
  • add regression coverage for standard and custom HERMES_HOME roots

Problem

Kanban's list_profiles_on_disk() only recognized named profiles stored under profiles/<name>/config.yaml. The implicit default profile lives at the Hermes root itself (~/.hermes or custom HERMES_HOME) and therefore showed up as on_disk: false in consumers like the dashboard / SwitchUI profiles list even though it is a real usable profile.

Fix

When the default Hermes root exists, include default in the discovered on-disk profile set. Keep existing named-profile enumeration unchanged.

Test Plan

  • ~/.hermes/hermes-agent/venv/bin/python -m pytest tests/hermes_cli/test_kanban_core_functionality.py -q -n 4 -k 'list_profiles_on_disk or known_assignees or pid_alive or detect_crashed_workers'

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard labels May 5, 2026
@alt-glitch
Copy link
Copy Markdown
Collaborator

Related to #19020, #19017 — extends the HERMES_HOME-aware profile discovery to also include the implicit default profile.

@teknium1
Copy link
Copy Markdown
Contributor

teknium1 commented May 5, 2026

Merged via PR #20170 (commit 542e06c). Your commit was cherry-picked onto current main with your authorship preserved in git log. Thanks — clean fix with good test coverage for both the standard and custom HERMES_HOME cases.

#20170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants