docs(discord): fix Server Members Intent + SSRC-mapping drift + /voice join slash Choice (salvage #11350)#20411
Merged
Merged
Conversation
…oice join slash Choice Salvage of #11350. Kept: - Code: add an explicit /voice join Choice in the slash UI (runner accepts both 'join' and 'channel' but only 'channel' was in autocomplete). - Docs: Server Members Intent is conditional (only needed if DISCORD_ALLOWED_USERS contains usernames); SSRC → user_id mapping uses the voice websocket SPEAKING opcode, not the Members intent. Dropped from the original PR: - HERMES_DISCORD_VOICE_PACKET_DUMP — this env var doesn't exist on main (it was in a different PR that isn't merged). - DISCORD_PROXY docs — already documented on current main. - DISCORD_ALLOW_MENTION_* docs — already on main. - "barge-in mode" rewrite — current main actually does pause the listener during TTS (VoiceReceiver.pause() at discord.py:192); there is no barge_in_guard/barge_in_rms on main. Co-authored-by: Michel Belleau <michel.belleau@malaiwah.com>
alt-glitch
added
type/docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
/voice joinexplicit Choice on the Discord slash UI (runner already accepted both "join" and "channel", but only "channel" was in autocomplete). Fixes the Server Members Intent table in the voice-mode docs to match current code — intent is conditional (needed only whenDISCORD_ALLOWED_USERScontains usernames), and SSRC → user_id mapping uses the voice websocket SPEAKING opcode rather than the Members intent.Changes:
gateway/platforms/discord.py— add /voice join Choice (+5/-1)website/docs/user-guide/features/voice-mode.md— fix Members Intent + SSRC description (+2/-2)Dropped from the original PR — each with a specific reason:
HERMES_DISCORD_VOICE_PACKET_DUMPenv var — doesn't exist on main (landing in a different PR, not merged).DISCORD_PROXYdocs additions — already on current main.DISCORD_ALLOW_MENTION_*docs additions — already on current main.VoiceReceiver.pause()atdiscord.py:192actually does pause the listener during TTS on current main; there is nobarge_in_guard/barge_in_rmscode path.Verified against
gateway/platforms/discord.py:600(intents.members = any(not entry.isdigit() …)) and:156(_pausedflag).Closes #11350 via salvage.
Original PR by @malaiwah — authorship preserved.