Skip to content

fix(kanban): reset <code> background inside dashboard board#20687

Merged
teknium1 merged 2 commits into
mainfrom
hermes/hermes-9ddf5187
May 6, 2026
Merged

fix(kanban): reset <code> background inside dashboard board#20687
teknium1 merged 2 commits into
mainfrom
hermes/hermes-9ddf5187

Conversation

@teknium1
Copy link
Copy Markdown
Contributor

@teknium1 teknium1 commented May 6, 2026

Summary

Event payloads, run metadata, and markdown code blocks inside the kanban board are no longer hidden by the Nous DS global code { background: var(--midground) } fill.

Root cause

Nous DS ships a global rule that paints an opaque cream/yellow background on every <code> element. The kanban dashboard uses <code> for hermes-kanban-event-payload, hermes-kanban-run-meta, and markdown code. The DS rule won on specificity — cards rendered as unreadable chips.

Fix

Add a single scoped override at .hermes-kanban code { background: transparent; color: inherit; }. Higher specificity than bare code, cascades to all three sites — no per-selector patching needed.

Changes

  • plugins/kanban/dashboard/dist/style.css: +9 lines (one rule block)
  • scripts/release.py: AUTHOR_MAP entry for @liuguangyong93

Alternatives considered

3 competing PRs (#20461, #19319, #18424) patched individual selectors downstream or added chip styling. All close as superseded by this root-cause fix.

Validation

  • tests/plugins/test_kanban_dashboard_plugin.py: 67/67 passing

Cherry-picked from PR #20648 by @liuguangyong93, authorship preserved.

teknium1 and others added 2 commits May 6, 2026 04:08
The Nous DS globals.css applies a global rule:
  code { background: var(--midground); color: var(--background); }

This paints an opaque cream/yellow fill on every <code> element,
which hides text in the kanban drawer's event-payload, run-meta,
and worker-log panes (all rendered as <code>).

Fix: scope a reset inside .hermes-kanban so <code> elements inherit
their parent's color and stay transparent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants