Skip to content

fix(approval): require explicit truthy yolo env values #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aydnOktay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(approval): require explicit truthy yolo env values #2864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/tools/test_yolo_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,17 @@ def test_yolo_mode_empty_string_does_not_bypass(self, monkeypatch):
result = check_dangerous_command("rm -rf /", "local",
approval_callback=lambda *a: "deny")
assert not result["approved"]

@pytest.mark.parametrize("val", ["0", "false", "False", "no", "off"])
def test_yolo_mode_false_like_values_do_not_bypass(self, monkeypatch, val):
"""False-like values should not activate YOLO bypass."""
monkeypatch.setenv("HERMES_YOLO_MODE", val)
monkeypatch.setenv("HERMES_INTERACTIVE", "1")
monkeypatch.setenv("HERMES_SESSION_KEY", "test-session")

result = check_dangerous_command(
"rm -rf /",
"local",
approval_callback=lambda *a: "deny",
)
assert not result["approved"]
11 changes: 9 additions & 2 deletions tools/approval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@

logger = logging.getLogger(__name__)


def _is_truthy_env(var_name: str) -> bool:
"""Return True only for explicit truthy env values."""
val = os.getenv(var_name, "").strip().lower()
return val in ("1", "true", "yes", "on")


# =========================================================================
# Dangerous command patterns
# =========================================================================
Expand Down Expand Up @@ -377,7 +384,7 @@ def check_dangerous_command(command: str, env_type: str,
return {"approved": True, "message": None}

# --yolo: bypass all approval prompts
if os.getenv("HERMES_YOLO_MODE"):
if _is_truthy_env("HERMES_YOLO_MODE"):
return {"approved": True, "message": None}

is_dangerous, pattern_key, description = detect_dangerous_command(command)
Expand Down Expand Up @@ -452,7 +459,7 @@ def check_all_command_guards(command: str, env_type: str,

# --yolo or approvals.mode=off: bypass all approval prompts
approval_mode = _get_approval_mode()
if os.getenv("HERMES_YOLO_MODE") or approval_mode == "off":
if _is_truthy_env("HERMES_YOLO_MODE") or approval_mode == "off":
return {"approved": True, "message": None}

is_cli = os.getenv("HERMES_INTERACTIVE")
Expand Down
Loading