Make skill file writes atomic#551
Merged
teknium1 merged 1 commit intoMar 10, 2026
Merged
Conversation
Contributor
|
Merged locally with contributor credit (739eb67). Clean, well-implemented atomic write pattern — thanks for the contribution! 🙏 |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
Authored by aydnOktay. Adds _atomic_write_text() helper using tempfile.mkstemp() + os.replace() to prevent skill file corruption on crash/interrupt. All 7 write_text() calls in skill_manager_tool.py converted, including rollback writes during security scans.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
Authored by aydnOktay. Adds _atomic_write_text() helper using tempfile.mkstemp() + os.replace() to prevent skill file corruption on crash/interrupt. All 7 write_text() calls in skill_manager_tool.py converted, including rollback writes during security scans.
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
Authored by aydnOktay. Adds _atomic_write_text() helper using tempfile.mkstemp() + os.replace() to prevent skill file corruption on crash/interrupt. All 7 write_text() calls in skill_manager_tool.py converted, including rollback writes during security scans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
his PR hardens skill management operations by making all file writes atomic. The skill_manager_tool now uses a temporary file and os.replace() for writing SKILL.md and supporting files, preventing corruption if Hermes crashes or is interrupted mid-write. The change adds a _atomic_write_text() helper that handles temp file creation, content writing, and atomic replacement, and updates _create_skill, _edit_skill, _patch_skill, and _write_file to use it. Rollback operations during security scans are also atomic, ensuring skill files remain consistent even if errors occur