-
Notifications
You must be signed in to change notification settings - Fork 265
Closed
Labels
bugSomething isn't workingSomething isn't workinghelp wantedExtra attention is neededExtra attention is neededskyrl-train
Description
The flash-rl codepath is using an older version of vllm which is missing some openai compatible imports
This causes this error on attempting to run it:
Traceback (most recent call last):
File "/home/ray/default/SkyRL/skyrl-train/examples/flash_rl/main_dapo_flashrl.py", line 183, in main
ray.get(skyrl_entrypoint.remote(cfg))
File "/home/ray/.cache/uv/archive-v0/cS1L8YbgnNKlAgWJ3A1Mx/lib/python3.12/site-packages/ray/_private/auto_init_hook.py", line 22, in auto_init_wrapper
return fn(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^
File "/home/ray/.cache/uv/archive-v0/cS1L8YbgnNKlAgWJ3A1Mx/lib/python3.12/site-packages/ray/_private/client_mode_hook.py", line 104, in wrapper
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/home/ray/.cache/uv/archive-v0/cS1L8YbgnNKlAgWJ3A1Mx/lib/python3.12/site-packages/ray/_private/worker.py", line 2858, in get
values, debugger_breakpoint = worker.get_objects(object_refs, timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ray/.cache/uv/archive-v0/cS1L8YbgnNKlAgWJ3A1Mx/lib/python3.12/site-packages/ray/_private/worker.py", line 958, in get_objects
raise value.as_instanceof_cause()
ray.exceptions.RayTaskError(ImportError): ray::skyrl_entrypoint() (pid=166149, ip=10.0.121.184)
File "/home/ray/default/SkyRL/skyrl-train/examples/flash_rl/main_dapo_flashrl.py", line 171, in skyrl_entrypoint
exp.run()
File "/tmp/ray/session_2025-10-20_19-21-41_275810_3510/runtime_resources/working_dir_files/_ray_pkg_92e7f2ab84dd141e/skyrl_train/entrypoints/main_base.py", line 284, in run
trainer = self._setup_trainer()
^^^^^^^^^^^^^^^^^^^^^
File "/home/ray/default/SkyRL/skyrl-train/examples/flash_rl/main_dapo_flashrl.py", line 141, in _setup_trainer
inference_engines = create_ray_wrapped_inference_engines_from_config_flashrl(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ray/default/SkyRL/skyrl-train/examples/flash_rl/main_dapo_flashrl.py", line 26, in create_ray_wrapped_inference_engines_from_config_flashrl
from examples.flash_rl.flash_rl_engine import create_ray_wrapped_inference_engines_flashrl
File "/tmp/ray/session_2025-10-20_19-21-41_275810_3510/runtime_resources/working_dir_files/_ray_pkg_92e7f2ab84dd141e/examples/flash_rl/flash_rl_engine.py", line 4, in <module>
from skyrl_train.inference_engines.vllm.vllm_engine import VLLMInferenceEngine
File "/tmp/ray/session_2025-10-20_19-21-41_275810_3510/runtime_resources/working_dir_files/_ray_pkg_92e7f2ab84dd141e/skyrl_train/inference_engines/vllm/vllm_engine.py", line 15, in <module>
from vllm.entrypoints.openai.protocol import (
ImportError: cannot import name 'ErrorInfo' from 'vllm.entrypoints.openai.protocol' (/home/ray/.cache/uv/archive-v0/cS1L8YbgnNKlAgWJ3A1Mx/lib/python3.12/site-packages/vllm/entrypoints/openai/protocol.py)Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinghelp wantedExtra attention is neededExtra attention is neededskyrl-train