[tx] Use WAL mode for sqlite#1054
Merged
pcmoritz merged 2 commits intoNovaSky-AI:mainfrom Feb 8, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables WAL mode for SQLite databases, which is a great improvement for allowing concurrent reads and writes. The implementation correctly uses SQLAlchemy events to set the necessary PRAGMAs for new connections. I've added one suggestion to improve the new function's maintainability by adding a type hint and removing a magic number. Overall, this is a solid change.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
pcmoritz
added a commit
that referenced
this pull request
Feb 13, 2026
…1105) This PR increases the busy timeout introduced in #1054 from 5s to 30s. If two writers to the database are active at the same time, the second writer will wait up to busy_timeout milliseconds and give an error `database is locked` if it cannot get a lock during that time. In a separate PR, I will also go through all the write transaction and make sure they are short lived (e.g. the transactions shouldn't be open while a checkpoint is written). <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/novasky-ai/skyrl/pull/1105" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enable WAL mode to allow reading the database while it is being written to (by a single writer). We also activate busy_timeout so multiple writers will retry to avoid 'database is locked' errors.