[docs][trivial] Add libnuma error in installation page#196
Merged
CharlieFRuan merged 2 commits intoNovaSky-AI:mainfrom Aug 25, 2025
Merged
[docs][trivial] Add libnuma error in installation page#196CharlieFRuan merged 2 commits intoNovaSky-AI:mainfrom
CharlieFRuan merged 2 commits intoNovaSky-AI:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a helpful note to the installation documentation regarding a potential error if libnuma is not set up correctly. The change is clear and placed in a logical location. My review includes a minor suggestion to ensure consistent formatting with the rest of the document.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
dzorlu
referenced
this pull request
in fleet-ai/SkyRL
Feb 4, 2026
We add the potential error that users might run into if libnuma is not set up, helping them triage errors better. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small follow-up to #191, we add the potential error that users might run into if libnuma is not setup, helping them triage errors better.