Clarify ObsType and the observation number#207
Merged
tyler-griggs merged 1 commit intoNovaSky-AI:mainfrom Aug 26, 2025
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively clarifies the distinction between observation and observations by updating docstrings and type hints. The change from str to ConversationType for ObsType in BaseTextEnv makes the expected data structure much clearer. I have one minor suggestion to further improve the clarity in a docstring to align with the goals of this PR. For full consistency, you might want to perform a global search for observation in docstrings to catch any remaining instances.
tyler-griggs
approved these changes
Aug 26, 2025
tyler-griggs
added a commit
that referenced
this pull request
Aug 27, 2025
#207 just corrected an error in `BaseTextEnv`. This PR propagates it to the docs
dzorlu
referenced
this pull request
in fleet-ai/SkyRL
Feb 4, 2026
This PR clarify the difference between `observation` and `observations`, and that `ObsType` holds the latter in the `Env` class. resolves #198
dzorlu
referenced
this pull request
in fleet-ai/SkyRL
Feb 4, 2026
#207 just corrected an error in `BaseTextEnv`. This PR propagates it to the docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clarify the difference between
observationandobservations, and thatObsTypeholds the latter in theEnvclass.resolves #198