[logs] Change print warnings to logger.warning#219
Merged
tyler-griggs merged 7 commits intoNovaSky-AI:mainfrom Aug 29, 2025
Merged
[logs] Change print warnings to logger.warning#219tyler-griggs merged 7 commits intoNovaSky-AI:mainfrom
tyler-griggs merged 7 commits intoNovaSky-AI:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a good step towards improving logging by replacing print statements with logger.warning. My review focuses on a consistent pattern across the changes: the log messages still contain a "WARNING: " prefix, which is redundant when using a leveled logger like logger.warning. I've suggested removing this prefix in all occurrences for cleaner and more idiomatic logging.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
tyler-griggs
approved these changes
Aug 29, 2025
dzorlu
referenced
this pull request
in fleet-ai/SkyRL
Feb 4, 2026
There are various places in the repo where we do `print("WARNING:...")`
which can be annoying. This PR changes them to `logger.warning()`.
There are still various print statements throughout the repo, but I will
fix the warnings one first.
Related to NovaSky-AI#168
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are various places in the repo where we do
print("WARNING:...")which can be annoying. This PR changes them tologger.warning().There are still various print statements throughout the repo, but I will fix the warnings one first.
Related to #168