[fix] Add missing required argument to OpenAIServingChat#247
Merged
tyler-griggs merged 1 commit intomainfrom Sep 6, 2025
Merged
[fix] Add missing required argument to OpenAIServingChat#247tyler-griggs merged 1 commit intomainfrom
tyler-griggs merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a crash by adding the missing request_logger argument to the OpenAIServingChat constructor. My review includes a suggestion to make this new argument configurable rather than hardcoding it to None. This would improve maintainability and align with existing TODO comments about enhancing debugging capabilities.
CharlieFRuan
approved these changes
Sep 6, 2025
dzorlu
referenced
this pull request
in fleet-ai/SkyRL
Feb 4, 2026
`request_logger` is a required argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request_loggeris a required argument.