Merged
Conversation
tyler-griggs
commented
Jun 25, 2025
Member
Author
There was a problem hiding this comment.
Moved, not deleted.
SumanthRH
reviewed
Jun 25, 2025
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("--output_dir", default="~/data/gsm8k") | ||
| parser.add_argument("--output_dir", default="/home/ubuntu/tgriggs/SkyRL/skyrl-train/data/gsm8k") |
SumanthRH
reviewed
Jun 25, 2025
| - deepspeed_config@deepspeed_config.train: train | ||
| - deepspeed_config@deepspeed_config.eval: eval | ||
| - skygym_config@skygym: default | ||
| - skyrl_gym_config@skyrl_gym: default |
Member
There was a problem hiding this comment.
can also just use gym_config because there's only one that is baked in
Member
Author
There was a problem hiding this comment.
But may as well stick with skyrl_gym? The full name skyrl_gym_config will be used only right here so it's not too big a deal
SumanthRH
reviewed
Jun 25, 2025
| from skyrl_train.generators.skyrl_gym_generator import SkyRLGymGenerator | ||
|
|
||
| return SkyGymGenerator( | ||
| return SkyRLGymGenerator( |
Member
Author
There was a problem hiding this comment.
My mind has been reading "SkyRL" as pronounced "schiral" and it makes all names sound better XD
SumanthRH
reviewed
Jun 25, 2025
Member
There was a problem hiding this comment.
There's a recent PR #30 which added "skygym" config to a example. Can you merge from main and search for skygym again
fannie1208
pushed a commit
to vinid/SkyRL
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skyrl-gymskyrl_gymSkyRL-gymand sometimesSkyRL Gym