fix: Updated utils.py to fix stop token issue#56
Merged
erictang000 merged 1 commit intoNovaSky-AI:mainfrom Jul 4, 2025
Merged
Conversation
erictang000
approved these changes
Jul 4, 2025
Collaborator
erictang000
left a comment
erictang000
left a comment
There was a problem hiding this comment.
makes sense, thanks for reporting and fixing this issue!
fannie1208
pushed a commit
to vinid/SkyRL
that referenced
this pull request
Aug 19, 2025
I was getting this error when passing adding stop tokens to generator config by passing a `"stop": [token1, token2, ...]` ``` (VLLMInferenceEngine pid=132934) File "/home/ubuntu/.cache/uv/builds-v0/.tmpqd4VTJ/lib/python3.12/site-packages/vllm/sampling_params.py", line 378, in __post_init__ (VLLMInferenceEngine pid=132934) self._verify_args() (VLLMInferenceEngine pid=132934) File "/home/ubuntu/.cache/uv/builds-v0/.tmpqd4VTJ/lib/python3.12/site-packages/vllm/sampling_params.py", line 444, in _verify_args (VLLMInferenceEngine pid=132934) assert isinstance(self.stop, list) (VLLMInferenceEngine pid=132934) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ (VLLMInferenceEngine pid=132934) AssertionError ``` this change fixes it, stop tokens can be added to generator config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting this error when passing adding stop tokens to generator config by passing a
"stop": [token1, token2, ...]this change fixes it, stop tokens can be added to generator config