[skyrl-train] Make libnuma optional for training#601
Merged
SumanthRH merged 1 commit intoNovaSky-AI:mainfrom Oct 30, 2025
Merged
[skyrl-train] Make libnuma optional for training#601SumanthRH merged 1 commit intoNovaSky-AI:mainfrom
libnuma optional for training#601SumanthRH merged 1 commit intoNovaSky-AI:mainfrom
Conversation
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request makes libnuma optional for training by wrapping the library loading in a try-except block. My review focuses on making this error handling more robust by catching a more specific exception, explicitly handling the case where the library is not found, and adjusting the log level to better reflect that this is an expected condition for an optional dependency. These changes will improve the clarity of log messages and prevent potential confusion from unexpected errors.
li-boxuan
pushed a commit
to li-boxuan/SkyRL
that referenced
this pull request
Nov 23, 2025
# What does this PR do? Makes `libnuma` optional for training Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
dzorlu
pushed a commit
to fleet-ai/SkyRL
that referenced
this pull request
Feb 4, 2026
# What does this PR do? Makes `libnuma` optional for training Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
libnumaoptional for training