Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes the markdown table formatting in the dapo/README.md file by adding the missing column separator. While reviewing, I noticed that all three reproduction runs in the table point to the same WandB link. This might be a copy-paste error that you may want to address. Since this is on lines not modified in this PR, I'm mentioning it here for your consideration.
| ## Reproduction Runs | ||
| | Recipe | Model | AIME24 Pass@32 | AIME24 Avg Score | Hardware | Training Steps | WandB | | ||
| |---|---|---|---|---|---| | ||
| |---|---|---|---|---|---|---| |
Contributor
There was a problem hiding this comment.
The number of separators is now correct, which fixes the table rendering. For improved source readability and to be more explicit about column alignment, consider using alignment syntax. For example, |:--| for left-aligned columns.
Suggested change
| |---|---|---|---|---|---|---| | |
| |:--|:--|:--|:--|:--|:--|:--| |
li-boxuan
pushed a commit
to li-boxuan/SkyRL
that referenced
this pull request
Nov 23, 2025
^ <img width="973" height="297" alt="image" src="https://github.com/user-attachments/assets/7f261daf-2b1d-482c-84b4-739c8b3df774" />
dzorlu
pushed a commit
to fleet-ai/SkyRL
that referenced
this pull request
Feb 4, 2026
^ <img width="973" height="297" alt="image" src="https://github.com/user-attachments/assets/7f261daf-2b1d-482c-84b4-739c8b3df774" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^