Merged
Conversation
This reverts commit e243324.
Collaborator
|
Nice catch! For the time being, it might be worth configuring the pyproject.toml in sky-trainer to use the checked out version of sky-gym, so we can move faster on these kinds of things and not wait for a release. I believe uv should support that. EDIT: Seems like we also need to symlink it |
tyler-griggs
added a commit
that referenced
this pull request
Jul 10, 2025
Reverts #67 Users are getting errors with the update to `_init_tool_groups` (from `init_tool_groups`) related to fixed skyrl-gym. Will revert this and fix. ``` File "/tmp/ray/session_2025-07-08_01-27-39_405126_2918156/runtime_resources/working_dir_files/_ray_pkg_32090e37b3aa13c5/examples/exp/search/env.py", line 31, in __init__ self._init_tool_groups([self.tool_group]) ^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'ExpSearchEnv' object has no attribute '_init_tool_groups'. Did you mean: 'init_tool_groups'?. Did you mean: '_return_value'? ```
fannie1208
pushed a commit
to vinid/SkyRL
that referenced
this pull request
Aug 19, 2025
Reverts NovaSky-AI#67 Users are getting errors with the update to `_init_tool_groups` (from `init_tool_groups`) related to fixed skyrl-gym. Will revert this and fix. ``` File "/tmp/ray/session_2025-07-08_01-27-39_405126_2918156/runtime_resources/working_dir_files/_ray_pkg_32090e37b3aa13c5/examples/exp/search/env.py", line 31, in __init__ self._init_tool_groups([self.tool_group]) ^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'ExpSearchEnv' object has no attribute '_init_tool_groups'. Did you mean: 'init_tool_groups'?. Did you mean: '_return_value'? ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #67
Users are getting errors with the update to
_init_tool_groups(frominit_tool_groups). Because skyrl-train uses the skyrl-gym package (instead of the source), changes to skyrl-gym are not picked up until a new package is released. Will revert this and fix.