Skip to content

Disable pack determinism because of unforeseen impact on deployment tools - #3060

Merged
nkolev92 merged 2 commits into
devfrom
dev-nkolev92-disableDeterministicPack
Sep 18, 2019
Merged

Disable pack determinism because of unforeseen impact on deployment tools#3060
nkolev92 merged 2 commits into
devfrom
dev-nkolev92-disableDeterministicPack

Conversation

@nkolev92

@nkolev92 nkolev92 commented Sep 17, 2019

Copy link
Copy Markdown
Member

Bug

Fixes: NuGet/Home#8599
Regression: No

  • Last working version:
  • How are we preventing it in future:

Fix

Details: Porting #3058

Follow up to 5.3 NuGet/Home#8602
Follow up in 5.4 NuGet/Home#8602

Testing/Validation

Tests Added: No, disabled the ones testing the feature.
Reason for not adding tests:
Validation:

Comment thread src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs Outdated
@nkolev92
nkolev92 merged commit 84230f1 into dev Sep 18, 2019
@nkolev92
nkolev92 deleted the dev-nkolev92-disableDeterministicPack branch September 18, 2019 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable pack determinism because of unforeseen impact on deployment tools

2 participants