Skip to content

Migrate XPlat to System.CommandLine#7260

Draft
zivkan wants to merge 8 commits intodevfrom
dev-zivkan-xplat-commandline-library
Draft

Migrate XPlat to System.CommandLine#7260
zivkan wants to merge 8 commits intodevfrom
dev-zivkan-xplat-commandline-library

Conversation

@zivkan
Copy link
Copy Markdown
Member

@zivkan zivkan commented Apr 7, 2026

Bug

Fixes: NuGet/Home#14848

Description

Used copilot to migrate from Microsoft.Extensions.CommandLineUtils.Sources to System.CommandLine.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests no behavior changes expected, but tests needed to be updated in some cases
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. N/A

@zivkan zivkan marked this pull request as ready for review April 10, 2026 21:21
@zivkan zivkan requested a review from a team as a code owner April 10, 2026 21:21
@jeffkl jeffkl requested a review from Copilot April 13, 2026 17:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

Seems like there was a stylistic departure halfway through the whole thing, that should be addressed. I don't get the static usage.

Comment thread src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Signing/VerifyCommand.cs Outdated
Comment thread src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/DeleteCommand.cs Outdated
Comment thread src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/LocalsCommand.cs Outdated
Comment thread src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/NuGetUpdateCommand.cs Outdated
Comment thread src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/PushCommand.cs Outdated
Comment thread src/NuGet.Core/NuGet.CommandLine.XPlat/GlobalSuppressions.cs Outdated
Comment thread test/NuGet.Core.FuncTests/NuGet.XPlat.FuncTest/XPlatLocalsTests.cs
@jeffkl jeffkl marked this pull request as draft April 14, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate NuGet's dotnet CLI commands to System.CommandLine

3 participants