Invalid Json in OpenAPI-Specification/schemas/v3.1/schema.json

[seriousme]

Hi,

my Github action to check for new OAS versions detected invalid JSON at:

OpenAPI-Specification/schemas/v3.1/schema.json

Lines 774 to 778 in 917d330

	"patternProperties": {
	"^[1-5](?:[0-9]{2}|XX)$":
	"$ref": "#/$defs/response-or-reference"
	}
	},

Kind regards,
Hans

[tmartin-git]

Maybe missing a '{'
=> Should be:
"^[1-5](?:[0-9]{2}|XX)$": {

[seriousme]

Looks like it.

Issue seems to be introduced by #2706 which seems to have been merged despite a failing test:
https://github.com/OAI/OpenAPI-Specification/runs/3690229683

Kind regards,
Hans

[seriousme]

Fixed, thx!

[jdesrosiers]

@seriousme You caught us in the middle of a multi-step process of releasing a new version of the schema. I suggest changing your Github Action so it looks for new versions (from the website)[https://github.com/OAI/OpenAPI-Specification/tree/gh-pages/oas/3.1/schema] instead. When we release a new version of the schema, this is where they get published. What's in the repo can sometimes be incomplete because we don't release a new version for every PR that we get.

[seriousme]

Clear !

Few questions though:
a) does this mean that the pre-3.1 schemes never change again ? (They don't seem to be present on the gh-pages branch.)
b) what happens if post-3.1 schemes emerge ? (e.g. will the oas/3.1 folder disappear ?)

Kind regards,
Hans

[jdesrosiers]

This is a new process that I introduced for v3.1, so that's why you don't see any 3.0 schemas published there yet. This next release will have a v3.0 update and I will be publishing that to the website. I don't plan to add older releases to website, but I can if people ask for it. The bottom line is that going forward, all schema updates will be published to the website. Once a version is published, it will not be removed. Hope that was clear.

[seriousme]

Thanks for the explanation!
Having the old versions available on the website would be nice as tools (like mine ;-)) still support the 2.0 and 3.0 version.
One "official" place to look for these versions (e.g. referred to in the FAQ) would be nice, I picked them up from master but I just learned that is your WIP branch ;-)

[seriousme]

Btw: ideally there would be an API(;-)) to check for new versions.

[jdesrosiers]

The process could certainly use some improvements, but with all volunteer work, you often end up with a minimal viable solution rather than an ideal solution 😞.