Skip to content

Add additionalProperties to Schema Object Documentation #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Smolations opened this issue Feb 25, 2015 · 6 comments
Closed

Add additionalProperties to Schema Object Documentation #285

Smolations opened this issue Feb 25, 2015 · 6 comments

Comments

@Smolations
Copy link

There is an example under the Schema Object definition which uses the "additionalProperties" key, but it is not specified as a possible key in the above spec.

@analogue
Copy link
Contributor

So all that is left here is updating the docs in 2.0.md?

@webron
Copy link
Member

webron commented Mar 11, 2015

@analogue - you can see the link to the commit in the issue. It'll be available once I merge the fixes with master.

@analogue
Copy link
Contributor

@webron As I understand it, there are two things that need to done to resolve this issue.

  • Update the jsonschema for the Swagger Specificiation to support additionalProperties on object types. This appears in commit 989544c
  • Update the list of properties in https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md#schema-object to include additionalProperties. This item is the reason for my original question. Without this update, it is not apparent from reading the spec that additionalProperties is even supported (except for the usage in an example which begs the question "Is this an error in the spec or an error in the example?").

@webron
Copy link
Member

webron commented Mar 11, 2015

Oh wow, I was sure I added that as well already. Thanks for bring it up, will be available in the fixes branch shortly.

webron added a commit that referenced this issue Mar 11, 2015
@webron
Copy link
Member

webron commented Mar 11, 2015

Done.

@Smolations
Copy link
Author

Thanks everyone! 👍

@webron webron closed this as completed in 989544c Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants