-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Make registry internal links relative [gh-pages] #3179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @handrews - are we sure this won't break the main site which is deployed without a directory name? I seem to recall I had difficulty making it work for both cases? Not that I hate jekyll or anything. |
This allows renderings of forks to work.
@MikeRalphson I actually missed some links, the most recent commit should be correct (I could have sworn I tested those pages... blah). There could be jekyll weirdness that might prevent this from working, I have no idea how to test it, though. OpenAPI is using a custom domain, and I do not, so I don't know if that's a concern. I can't think of any reason why it wouldn't work, as the |
It looks like I set up https://spec.mermade.org.uk/ in the dim and distant past for testing, so will pull your changes. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from two tiny nits. Tested at https://spec.mermade.org.uk/
Co-authored-by: Mike Ralphson <[email protected]>
Co-authored-by: Mike Ralphson <[email protected]>
Thanks for the thorough testing @MikeRalphson — I committed both of your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks.
Thanks for everyone involved! |
This allows renderings of forks to work. Otherwise the links all 404 because forks are rendered under a directory name.