Skip to content

Make registry internal links relative [gh-pages] #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

handrews
Copy link
Member

@handrews handrews commented Mar 1, 2023

This allows renderings of forks to work. Otherwise the links all 404 because forks are rendered under a directory name.

@MikeRalphson
Copy link
Member

Thanks @handrews - are we sure this won't break the main site which is deployed without a directory name? I seem to recall I had difficulty making it work for both cases? Not that I hate jekyll or anything.

This allows renderings of forks to work.
@handrews
Copy link
Member Author

handrews commented Mar 1, 2023

@MikeRalphson I actually missed some links, the most recent commit should be correct (I could have sworn I tested those pages... blah).

There could be jekyll weirdness that might prevent this from working, I have no idea how to test it, though. OpenAPI is using a custom domain, and I do not, so I don't know if that's a concern.

I can't think of any reason why it wouldn't work, as the ./ should just go relative to the root, but... jekyll (I unabashedly hate jekyll).

@MikeRalphson MikeRalphson self-assigned this Mar 1, 2023
@MikeRalphson
Copy link
Member

It looks like I set up https://spec.mermade.org.uk/ in the dim and distant past for testing, so will pull your changes. Thanks.

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from two tiny nits. Tested at https://spec.mermade.org.uk/

handrews and others added 2 commits March 2, 2023 11:02
@handrews
Copy link
Member Author

handrews commented Mar 2, 2023

Thanks for the thorough testing @MikeRalphson — I committed both of your suggestions.

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.

@MikeRalphson MikeRalphson changed the title Make links relative Make registry internal links relative [gh-pages] Mar 3, 2023
@whitlockjc whitlockjc merged commit 6c3caaa into OAI:gh-pages Mar 3, 2023
@whitlockjc
Copy link
Member

Thanks for everyone involved!

@handrews handrews deleted the relative branch March 4, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants