Skip to content

- adds a char format description #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Mar 3, 2023

related #3167

Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an impulse to note that it's more reliable for validation to use this alongside minLength and maxLength, but you can say similar things about all uses of format so it's probably best to not complicate things.

@baywet
Copy link
Contributor Author

baywet commented Mar 6, 2023

@handrews people could use both:

  • min set to 1
  • max set to 1
  • format char

This way they'd have validation from both tooling that doesn't understand the format and from the tooling that does. Do you think we should add a note?

@handrews
Copy link
Member

handrews commented Mar 6, 2023

@baywet no, it's probably best not to as we'd then want to add notes to all of the formats about how to compensate for format support being a dumpster fire in general. People use format at their own risk, and (having thought about it a bit more since writing that comement), the registry is not the right place to try to mitigate that.

@baywet
Copy link
Contributor Author

baywet commented Mar 6, 2023

makes sense. I do think there should be a place for "things that are not normatize but that people should consider". Kind of a collection of best practices if that makes sense.

@MikeRalphson
Copy link
Member

makes sense. I do think there should be a place for "things that are not normatize but that people should consider". Kind of a collection of best practices if that makes sense.

@baywet in the absence of a set of technical notes or authorative blog posts, possibly https://github.com/OAI/Documentation/blob/main/best-practices.md ?

@baywet
Copy link
Contributor Author

baywet commented Mar 7, 2023

Thanks. This is a bit buried, does it get published anywhere? Should we move it to the GitHub pages branch?

@MikeRalphson
Copy link
Member

This is a bit buried, does it get published anywhere? Should we move it to the GitHub pages branch?

A separate repo was considered preferable, I think partly due to different licensing (CC versus Apache-2.0). It is published at https://oai.github.io/Documentation and linked to from the website, but there are plans afoot to create a https://learn.openapis.org subdomain.

@baywet
Copy link
Contributor Author

baywet commented Mar 7, 2023

Thanks, let log an issue to document that "best practice" should this format get merged.

@MikeRalphson
Copy link
Member

@baywet OAI/learn.openapis.org#42

@baywet
Copy link
Contributor Author

baywet commented Mar 13, 2023

@darrelmiller I believe this one is good to be merged as we've been through all the review comments.

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baywet baywet mentioned this pull request Mar 14, 2023
@darrelmiller darrelmiller merged commit 660331f into OAI:gh-pages Mar 16, 2023
@baywet baywet deleted the feature/char-format branch March 16, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants