-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Add essential policies to DEVELOPMENT.md #3599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In yet another attempt to prevent people from opening PRs that we cannot accept.
We could also name this file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a commitment to update the list of open branches, but I think it's worth it since we have to type it into half the pull requests we get anyway. I made a small suggestion, happy to review again at any time.
DEVELOPMENT.md
Outdated
|
||
If in doubt about a policy, please [ask on our Slack](https://communityinviter.com/apps/open-api/openapi) before opening a PR. | ||
|
||
_Note that the later sections of this document have not been updated recently. Until that has happened, if this section and later sections disagree, this section is to be considered the current policy._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd discourage adding time-sensitive content into a file we will probably continue to fail to update. Directing people to slack is the right thing in almost every case of confusion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lornajane yeah... I'm not sure what to do here. This file is huge, and a lot of it needs rewriting. I'd almost rather delete everything that's not current. Better to have undefined processes that documentation that is, at this point, outright wrong.
@lornajane I'd be quite happy to move it to CONTRIBUTING. I thought we had one that was used for something else, but we have CONTRIBUTORS. Which is also not used in a normal way as it's the TSC list, not the contributor list. I'm also hesitant to add time-sensitive information, but like you said, we have to type it in so often anyway, at least this way we could point to an "official" document. I've noticed not everyone will go to Slack, much less ask a question there. |
|
||
#### Changing the schemas | ||
|
||
Schemas are only changed _after_ the specification is changed. Changes are made on the `main` branch, and should be made to the YAML version _only_. The JSON version will be generated automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't sound right because there are a number of schema changes in the v3.1.1-dev branch (mostly fixes to restore conformance with the spec).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - could there/should there be an automated script that updates the json file immediately after a merged change to the yaml file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't sound right because there are a number of schema changes in the v3.1.1-dev branch (mostly fixes to restore conformance with the spec).
I think those are ones that got merged by accident because someone didn't see that the branch was wrong. Although for 3.2 you are probably right, as it will get a new schema (but patch releases do not). Honestly, I'm not sure, I'm kind of trying to provoke some sort of clear policy.
Also - could there/should there be an automated script that updates the json file immediately after a merged change to the yaml file?
That would be great, but would require someone to do it. We could use forward-porting scripts that are more per-change oriented than the ones in the scripts
directory and automation to forward-port individual PRs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those are ones that got merged by accident because someone didn't see that the branch was wrong.
I believe they were intentional.. there was even a new interim release made of the revised schema (about a year ago now) - "$id": "https://spec.openapis.org/oas/3.1/schema/2022-10-07"
. There have been enough commits since then that we could have another interim release now.
I am not sure I've ever read this whole page before, we can definitely lose some of it! Your additions are a good enhancement so let's start there. I still think we should avoid the time-sensitive disclaimer, but without it, I'm happy and the other changes can follow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very good as it stands, thanks for adding it!
The two tables "Current branches and documents open to change" and https://github.com/OAI/OpenAPI-Specification/blob/4a11c66836f7e3a0b9246a98849428bbc55ea8fd/DEVELOPMENT.md#tracking-process seem to be at odds.
|
@lornajane @AxelNennker 's comment is why I had that disclaimer... :/ Since it's approved, I'm going to merge this and then someone with more time than me can reconcile it. |
In yet another attempt to prevent well-meaning people from opening PRs that we cannot accept. It turns out that if you make a PR template, it puts the template info below the commit message so people often don't see it.