Skip to content

Update 3.1.1 Spec for Style Values #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

charjr
Copy link
Contributor

@charjr charjr commented Mar 28, 2024

Resolves #3682

Will also make a PR to fix this in 3.0.4

@charjr charjr changed the title Update Spec for Style Values Update 3.1.1 Spec for Style Values Mar 28, 2024
@charjr charjr force-pushed the update-style-docs branch from dac03c2 to ec7df96 Compare March 28, 2024 19:18
@handrews handrews added the param serialization Issues related to parameter and/or header serialization label Mar 28, 2024
Comment on lines 1060 to 1061
spaceDelimited | `array`, `object` | `query` | Space separated array or object values. This option replaces `collectionFormat` equal to `ssv` from OpenAPI 2.0.
pipeDelimited | `array`, `object` | `query` | Pipe separated array or object values. This option replaces `collectionFormat` equal to `pipes` from OpenAPI 2.0.
Copy link
Member

@karenetheridge karenetheridge Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to "array values or object properties and values" to be consistent with #3685 (for both spaceDelimited and pipeDelimited).

Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charjr

@lornajane lornajane merged commit 7ce6f88 into OAI:v3.1.1-dev Apr 17, 2024
1 check passed
@handrews handrews added this to the v3.1.1 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
param serialization Issues related to parameter and/or header serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants