Skip to content

Update ReSpec-rendered specification versions #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This pull request is automatically triggered by GitHub action respec.

The versions/*.md files have changed, so the HTML files are automatically being regenerated.

@github-actions github-actions bot force-pushed the update-respec-version branch 3 times, most recently from 48f768b to 951c3e8 Compare August 15, 2024 16:34
@ralfhandl ralfhandl requested a review from a team August 16, 2024 13:37
ralfhandl
ralfhandl previously approved these changes Aug 16, 2024
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the expected changes in all versions

@ralfhandl ralfhandl requested a review from a team August 16, 2024 14:21
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at latest.html and it looks good. I noticed the following:

  • changed canonical link, to point the the versioned filename (I think this is more correct than having latest be canonical)
  • updates to how the SPDX reference is linked
  • removed old manual reference entries
  • changes to big style blocks- I assume these are fine, they seem to be in the right place
  • two examples now point to the learn site
  • lots of nohighlight/highlight changes to add tabindex, which seem correct- I did not look at every one in detail, but as I saw different variations I spot-checked to make sure they were being handled in the same way after the change, which they seemed to be.

@ralfhandl ralfhandl requested a review from handrews August 19, 2024 07:42
@ralfhandl
Copy link
Contributor

@handrews' review was dismissed due to merging #4021 which didn't change anything in this PR.

@ralfhandl ralfhandl merged commit fb7ab6b into gh-pages Aug 19, 2024
@ralfhandl ralfhandl deleted the update-respec-version branch August 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants