-
Notifications
You must be signed in to change notification settings - Fork 9.1k
3.0.4: tables cleanup & markdownlint #4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
Left a comment to remove some unnecessary leading white space.
Co-authored-by: Mike Kistler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Update after #4027 is merged, check out .markdownlint.yaml from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
I expected to see the action running in this pull request, should it? |
Probably the merge conflict prevents the script from running. |
@handrews Added
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
I can't say I'm at all happy with Prettier's markdown behavior, but this is better than what it was doing to tables before. This double-change of every single table line is going to be such a pain for searching change history :-( Although if we do a lot of rearranging for 3.2 I guess it won't matter anyway. Plus searching change history is already incredibly hard in this repo. |
Me neither, but it does format the code blocks correctly.
Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
I was concerned that the prettier extension in VSCode (my preferred editing environment) might reflow the tables if I made any change to the file, but I tested this and found that not to be the case.
My VS Code does if I explicitly format the file with the prettier extension enabled, or if I have "format on save" turned on and save the file. Which is why I have both the extension disabled for this workspace and "format on save" turned off in the workspace settings 😎 |
This is why I use vi 😛 (ok technically vim, but that's my only concession to modernity!) |
vi was my preferred tool for editing the makefile for Emacs 😎 |
Merging as @mikekistler has already approved half a dozen times 😎 |
main
branchformat-markdown
to conveniently reformat markdown after changesPart of