Reorganization of best practices and addition of overlays for globals#201
Reorganization of best practices and addition of overlays for globals#201
Conversation
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
baywet
changed the title
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
lornajane
left a comment
lornajane
left a comment
There was a problem hiding this comment.
I love this! And sorry, I added loads of comments, should I have just edited? I know half of this isn't yours. The Overlays for global updates is great!
|
|
||
| However, they greatly simplify creating and maintaining OpenAPI Descriptions (OADs), so they are worth keeping in mind. | ||
|
|
||
| This section is split into topic-specific pages: |
There was a problem hiding this comment.
Are we going to correctly maintain this list every time we add or change content? Even if we've done this somewhere else, I'd be tempted to just lean on "check the pages in this section" or something
There was a problem hiding this comment.
thanks for the feedback, updated to use jekyll list instead of manually maintained one.
Co-authored-by: Lorna Jane Mitchell <github@lornajane.net>
Co-authored-by: Lorna Jane Mitchell <github@lornajane.net>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
|
@lornajane thanks for the review. I have "moved" the feedback on existing content to #203. I don't think we should address it here since:
Let me know if you still have suggestions on the overlay article, otherwise we should be good to merge as is and follow up with another PR to address the concerns you had on existing content. |
|
This makes sense. Let's work on the restructure so we've got somewhere to land this article! |
|
@lornajane let me know if you have any additional feedback specific to this new article. Otherwise it's ready for another review. |
2 participants
fixes #200
This does a couple of things:
Heavy use of GH Copilot to help with the reorganization and the wording