Skip to content

[10.0] Added analytic tags to contracts#110

Merged
pedrobaeza merged 1 commit into
10.0from
unknown repository
Mar 28, 2018
Merged

[10.0] Added analytic tags to contracts#110
pedrobaeza merged 1 commit into
10.0from
unknown repository

Conversation

@katyukha

Copy link
Copy Markdown
Contributor

This commit adds ability to specify analytic tags on contracts invoice
lines, which will be propagated to invoice lines.

@rafaelbn rafaelbn added this to the 10.0 milestone Jan 4, 2018
@pedrobaeza

Copy link
Copy Markdown
Member

Please rebase and solve conflicts.

@katyukha

Copy link
Copy Markdown
Contributor Author

Rebased

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'uom_id': line.uom_id.id,
'discount': line.discount,
})

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add line breaks inside methods

# Get other invoice line values from product onchange
invoice_line._onchange_product_id()
invoice_line_vals = invoice_line._convert_to_write(invoice_line._cache)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@katyukha

Copy link
Copy Markdown
Contributor Author

@pedrobaeza For module version what part of number is better to increase?
10.0.x.y.z : x or y? There only one field added, and module upgrade is required, but no migration needed.

Thanks for your review

@carlosdauden carlosdauden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank lines and change version

@katyukha

Copy link
Copy Markdown
Contributor Author

There is strange error on runbot

@pedrobaeza

Copy link
Copy Markdown
Member

Yeah, strange, and Travis has not been fired. Please change module version raising y letter, and see if now it works correctly.

This commit adds ability to specify analytic tags on contracts invoice
lines, which will be propagated to invoice lines.
@katyukha

Copy link
Copy Markdown
Contributor Author

Tests passed

@pedrobaeza pedrobaeza merged commit 08f2fac into OCA:10.0 Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants