[10.0] Added analytic tags to contracts#110
Conversation
|
Please rebase and solve conflicts. |
|
Rebased |
pedrobaeza
left a comment
There was a problem hiding this comment.
Please change module version number according https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers
| 'uom_id': line.uom_id.id, | ||
| 'discount': line.discount, | ||
| }) | ||
|
|
There was a problem hiding this comment.
Don't add line breaks inside methods
| # Get other invoice line values from product onchange | ||
| invoice_line._onchange_product_id() | ||
| invoice_line_vals = invoice_line._convert_to_write(invoice_line._cache) | ||
|
|
|
@pedrobaeza For module version what part of number is better to increase? Thanks for your review |
carlosdauden
left a comment
There was a problem hiding this comment.
Remove blank lines and change version
|
There is strange error on runbot |
|
Yeah, strange, and Travis has not been fired. Please change module version raising |
This commit adds ability to specify analytic tags on contracts invoice lines, which will be propagated to invoice lines.
|
Tests passed |
This commit adds ability to specify analytic tags on contracts invoice
lines, which will be propagated to invoice lines.