10.0 contract#40
Conversation
[IMP] contract: Add pre-paid invoicing type. Fix yearly
|
Travis is failing saying that |
|
No worries @pedrobaeza. That is why it's work in progress... |
StefanRijnhart
force-pushed
the
10.0-contract
branch
3 times, most recently
from
096aaef to
3a6d3e9
Compare
|
Now ready for review. Because the 10.0 branch had not received any changes I simply merged in the latest changes of 9.0. I hope that is alright. |
| @@ -21,16 +22,27 @@ To use this module, you need to: | |||
|
|
|||
| #. Go to Sales -> Contracts and select or create a new contract. | |||
There was a problem hiding this comment.
Contracts menu is not in Sales, it is in Invoicing menu.
There was a problem hiding this comment.
Thanks, I have realigned this description with reality.
susport
left a comment
susport
left a comment
There was a problem hiding this comment.
Validate that Date of Next Invoice is greater than the current date.
|
@susport I think being able to invoice retroactively could be useful in some cases so I would rather not implement the check you suggested. |
StefanRijnhart
force-pushed
the
10.0-contract
branch
from
e477f72 to
f82548b
Compare
| { | ||
| 'name': 'Contracts Management recurring', | ||
| 'version': '9.0.1.0.0', | ||
| 'version': '10.0.1.1.0', |
There was a problem hiding this comment.
10.0.1.0.0, as the first 10.0 version
| if self.date_start and self.recurring_invoices: | ||
| self.recurring_next_date = self.date_start | ||
|
|
||
| @api.model |
| # Get other invoice values from partner onchange | ||
| invoice._onchange_partner_id() | ||
| return invoice._convert_to_write(invoice._cache) | ||
| return invoice._convert_to_write( |
There was a problem hiding this comment.
Because in the case of empty values for many2one records, the cache contains an empty tuple instead of an empty recordset. The invoice record contains the correct value.
Before I added this change, this line broke the test. I took the modification from the Odoo core addons where it is used in several places.
There was a problem hiding this comment.
Uhm, that's something ugly that doesn't happen on v9. Another hack to take into account...
lasley
left a comment
lasley
left a comment
There was a problem hiding this comment.
LGTM thanks @StefanRijnhart
|
@StefanRijnhart, can you please squash last 4 commits into one before proceeding to merge? |
|
Thanks for the reviews. Discovered a bug though. @pedrobaeza about the squashing, that would remove credits so I'd rather not. |
|
@pedrobaeza Oh, the last four commits. Will do! |
|
No, what I want you to do is to squash your migration commits together. |
|
We have commented at the same time 😉 |
lasley
left a comment
lasley
left a comment
There was a problem hiding this comment.
contract_variable_quantity is included here, but not installable.
StefanRijnhart
force-pushed
the
10.0-contract
branch
from
d5744a0 to
6292acc
Compare
|
Ready for merging, rebased and all. The bug I experienced was related to another call to convert_to_write. However, the problem with this method was fixed upstream in odoo/odoo@51680426, so I could revert my changes to this call. |
|
I'm relief to see that we don't need to introduce a new hack. |
|
Merging this PR. @lasley, please rebase for your PR about variable_quantity. |
|
I see some changes in the menus, are they intentionally?
|
|
@rafaelbn Yes, sale menus are no longer available in Odoo 10.0 without the additional dependency on the sale module so I moved the menus to the accounting menu |
8 participants
No description provided.