Skip to content

[16.0][MIG] partner_contact_role: Migration to 16.0#1812

Merged
OCA-git-bot merged 13 commits into
OCA:16.0from
qrtl:16.0-mig-partner_contact_role
Aug 8, 2024
Merged

[16.0][MIG] partner_contact_role: Migration to 16.0#1812
OCA-git-bot merged 13 commits into
OCA:16.0from
qrtl:16.0-mig-partner_contact_role

Conversation

@AungKoKoLin1997

@AungKoKoLin1997 AungKoKoLin1997 commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

@qrtl QT4695

<record model="ir.actions.act_window" id="res_partner_role_act_window">
<field name="name">Partner Role</field>
<field name="res_model">res.partner.role</field>
<field name="view_mode">tree</field>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="view_mode">tree</field>
<field name="view_mode">tree,form</field>

Someone might be depending on this module to extend the form view, so we will keep the form view

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-partner_contact_role branch from 480b2af to 213cffe Compare July 10, 2024 08:54

@kanda999 kanda999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the comment of this PR?

License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
<odoo>
<record model="ir.ui.view" id="res_partner_role_form_view">
<field name="name">res.partner.role.tree</field>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="name">res.partner.role.tree</field>
<field name="name">res.partner.role.form</field>

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-partner_contact_role branch from 213cffe to dc9b0b3 Compare July 10, 2024 10:41

@kanda999 kanda999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function test.

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AungKoKoLin1997 As we just talked, let's separate the commits for migration and the enhancement (adding the active field).

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-partner_contact_role branch from dc9b0b3 to 4797633 Compare July 22, 2024 09:35

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

@AungKoKoLin1997

Copy link
Copy Markdown
Contributor Author

@oca/partner-contact-maintainers
Can you please take a look this migration PR?

@yajo yajo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1812-by-yajo-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 20c847d into OCA:16.0 Aug 8, 2024
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 115c2ac. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants