[16.0][MIG] partner_contact_role: Migration to 16.0#1812
Merged
Conversation
Currently translated at 100.0% (12 of 12 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_contact_role Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_contact_role/es/
kanda999
reviewed
Jul 10, 2024
| <record model="ir.actions.act_window" id="res_partner_role_act_window"> | ||
| <field name="name">Partner Role</field> | ||
| <field name="res_model">res.partner.role</field> | ||
| <field name="view_mode">tree</field> |
Contributor
There was a problem hiding this comment.
Suggested change
| <field name="view_mode">tree</field> | |
| <field name="view_mode">tree,form</field> |
Someone might be depending on this module to extend the form view, so we will keep the form view
480b2af to
213cffe
Compare
kanda999
reviewed
Jul 10, 2024
kanda999
left a comment
Contributor
There was a problem hiding this comment.
Could you please update the comment of this PR?
| License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). --> | ||
| <odoo> | ||
| <record model="ir.ui.view" id="res_partner_role_form_view"> | ||
| <field name="name">res.partner.role.tree</field> |
Contributor
There was a problem hiding this comment.
Suggested change
| <field name="name">res.partner.role.tree</field> | |
| <field name="name">res.partner.role.form</field> |
213cffe to
dc9b0b3
Compare
yostashiro
reviewed
Jul 22, 2024
yostashiro
left a comment
Member
There was a problem hiding this comment.
@AungKoKoLin1997 As we just talked, let's separate the commits for migration and the enhancement (adding the active field).
dc9b0b3 to
4797633
Compare
Contributor
Author
|
@oca/partner-contact-maintainers |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 115c2ac. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@qrtl QT4695