[16.0][MIG] mail_debrand by SodexisTeam · Pull Request #1021 · OCA/social

SodexisTeam · 2022-12-05T05:24:50Z

No description provided.

There's no commits preservation, as the module doesn't serve as is on v9.

without this fix, any regular notification (added as follower, thread notifications...) were not parsed at all and as a consequence also not debranded.

Currently translated at 40.0% (2 of 5 strings) Translation: social-12.0/social-12.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_debrand/pt/

Currently translated at 100.0% (5 of 5 strings) Translation: social-12.0/social-12.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_debrand/sl/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/

Currently translated at 20.0% (1 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/nl/

Currently translated at 100.0% (5 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/fr/

atchuthan · 2022-12-14T08:21:09Z

Hi,

thanks for this port. Any chance to also add this commit fc90272

@flotho Is this commit already available in v15? If no, I'll first include it in v15 first and then add it to v16 migration.

atchuthan · 2022-12-14T08:22:07Z

Please check these bugfixes proposed for 15.0: #939

@StefanRijnhart waiting for #939 to be merged. I'll include this fix after it is merged.

atchuthan · 2022-12-14T08:34:09Z

Hi,
thanks for this port. Any chance to also add this commit fc90272

@flotho Is this commit already available in v15? If no, I'll first include it in v15 first and then add it to v16 migration.

@flotho created a new PR #1026 for v15

StefanRijnhart · 2022-12-14T08:57:43Z

@atchuthan thanks for reviewing that one! It's up to you of course, but I think it's alright to already pick them into this branch. You can announce this in the PR description. Without them, the module is a bit broken and this PR is effectively blocked.

…of type 'NoneType' has no len()

Leonidas-VII · 2022-12-23T10:05:15Z

+|badge1| |badge2| |badge3| |badge4| |badge5| 
+
+This module modifies the functionality of emails to remove the Odoo branding,
+specifically the 'using Odoo' of notifications or the 'Powered by Odoo'


Hi, I have read this README and then reviewed it again in the code, it seems Odoo doesn't use the phrase "using Odoo" anymore for version 16.
So I think we should remove the phrase "using Odoo".

StefanRijnhart

Thanks! I wouldn't mind if you picked #1026 into this one already, given that it was included in 14.0 with so much support.

atchuthan · 2023-01-19T07:44:00Z

Thanks! I wouldn't mind if you picked #1026 into this one already, given that it was included in 14.0 with so much support.

We will create a separate PR for 16.0 once the PR(#1026) for 15.0 is merged in OCA

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2023-02-07T13:45:08Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1021-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2023-02-07T13:46:54Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1021-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot · 2023-02-07T13:48:59Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1021-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

StefanRijnhart · 2023-02-07T14:42:38Z

pre-commit is now fixed in #1065

pedrobaeza · 2023-02-07T15:07:19Z

/ocabot merge nobump

OCA-git-bot · 2023-02-07T15:07:26Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1021-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-02-07T15:11:39Z

Congratulations, your PR was merged at 3a7a18c. Thanks a lot for contributing to OCA. ❤️

Syncing from upstream OCA/social (16.0)

pedrobaeza and others added 30 commits December 5, 2022 10:45

[MIG] mail_debrand

e08112a

There's no commits preservation, as the module doesn't serve as is on v9.

OCA Transbot updated translations from Transifex

466c6f0

[11.0][MIG] mail_debrand

a1f506c

[UPD] Update mail_debrand.pot

3edd3f8

Rewrite mail_debrand for v12

1b9db92

[UPD] Update mail_debrand.pot

7a336b0

[FIX] Parse generated html to remove to remove Odoo branding messages

a89f21f

[UPD] Update mail_debrand.pot

e6dde23

[FIX] mail_debrand: Add development_status (OCA#408)

18d5a49

[UPD] README.rst

0698d56

[12.0][FIX] mail_debrand: debrand regular notifications.

8b10231

without this fix, any regular notification (added as follower, thread notifications...) were not parsed at all and as a consequence also not debranded.

[UPD] Update mail_debrand.pot

409e412

mail_debrand 12.0.2.0.1

113b08d

[UPD] README.rst

45eac19

Added translation using Weblate (French)

e7594d4

Added translation using Weblate (Portuguese)

c7ff829

Translated using Weblate (Portuguese)

7a65a49

Currently translated at 40.0% (2 of 5 strings) Translation: social-12.0/social-12.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_debrand/pt/

Added translation using Weblate (Slovenian)

53e9fc3

Added translation using Weblate (Serbian (latin))

d05ec44

Translated using Weblate (Slovenian)

e118f67

Currently translated at 100.0% (5 of 5 strings) Translation: social-12.0/social-12.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_debrand/sl/

[MIG] mail_debrand: Migration to v13.0

20a52c9

[UPD] Update mail_debrand.pot

e879795

[UPD] README.rst

65c0e3b

Update translation files

45a28c7

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/

Added translation using Weblate (Dutch)

51e9685

Translated using Weblate (Dutch)

0cd69ff

Currently translated at 20.0% (1 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/nl/

Translated using Weblate (French)

7ce4b44

Currently translated at 100.0% (5 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/fr/

Translated using Weblate (French)

88ec730

Currently translated at 100.0% (5 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/fr/

[FIX] support all languages, no need of translations

9dc5892

[UPD] README.rst

5f3957b

OCA-git-bot mentioned this pull request Dec 13, 2022

Migration to version 16.0 #974

Open

40 tasks

[15.0-mail] [FIX] mail_debrand: text/plain issue + TypeError: object …

586161d

…of type 'NoneType' has no len()

Leonidas-VII reviewed Dec 23, 2022

View reviewed changes

Comment thread mail_debrand/readme/DESCRIPTION.rst Outdated

SodexisTeam force-pushed the 16.0-mig-mail_debrand branch 3 times, most recently from 2278da5 to 586161d Compare December 27, 2022 07:25

[16.0][IMP] mail_debrand

6b003bf

StefanRijnhart approved these changes Jan 13, 2023

View reviewed changes

pedrobaeza approved these changes Feb 7, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Feb 7, 2023

OCA-git-bot added a commit that referenced this pull request Feb 7, 2023

Merge PR #1021 into 16.0

42a02ce

Signed-off-by pedrobaeza

OCA-git-bot removed the bot is merging ⏳ label Feb 7, 2023

OCA-git-bot added the bot is merging ⏳ label Feb 7, 2023

OCA-git-bot merged commit c71c37a into OCA:16.0 Feb 7, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 7, 2023

SiesslPhillip pushed a commit to grueneerde/OCA-social that referenced this pull request Nov 20, 2024

Merge pull request OCA#1021 from OCA/16.0

fbb1b96

Syncing from upstream OCA/social (16.0)

Uh oh!

Conversation

SodexisTeam commented Dec 5, 2022

Uh oh!

atchuthan commented Dec 14, 2022

Uh oh!

atchuthan commented Dec 14, 2022

Uh oh!

atchuthan commented Dec 14, 2022

Uh oh!

StefanRijnhart commented Dec 14, 2022

Uh oh!

Leonidas-VII Dec 23, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

atchuthan commented Jan 19, 2023

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Feb 7, 2023

Uh oh!

OCA-git-bot commented Feb 7, 2023

Uh oh!

OCA-git-bot commented Feb 7, 2023

Uh oh!

StefanRijnhart commented Feb 7, 2023

Uh oh!

pedrobaeza commented Feb 7, 2023

Uh oh!

OCA-git-bot commented Feb 7, 2023

Uh oh!

OCA-git-bot commented Feb 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants