Skip to content

[16.0][MIG] mail_outbound_static: Migration to 16.0#1035

Merged
OCA-git-bot merged 24 commits into
OCA:16.0from
ursais:16.0-mig-mail_outbound_static
Mar 20, 2023
Merged

[16.0][MIG] mail_outbound_static: Migration to 16.0#1035
OCA-git-bot merged 24 commits into
OCA:16.0from
ursais:16.0-mig-mail_outbound_static

Conversation

@dreispt

@dreispt dreispt commented Jan 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

No description provided.

@dreispt dreispt changed the title [MIG] mail_outbound_static: Migration to 16.0 [16.0][MIG] mail_outbound_static: Migration to 16.0 Jan 2, 2023
yostashiro
yostashiro suggested changes Jan 29, 2023
View reviewed changes

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt Thanks for the PR. Can you please check this commit qrtl@196f6b3 which I added on top of yours, and cherry-pick this as appropriate?

Comment thread mail_outbound_static/models/ir_mail_server.py
CasVissers-360ERP
CasVissers-360ERP approved these changes Feb 1, 2023
View reviewed changes

@CasVissers-360ERP CasVissers-360ERP left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it running for some months now, all good.

@adrienpeiffer

adrienpeiffer commented Feb 14, 2023

Copy link
Copy Markdown

Hi @dreispt
I have an issue related with the smtp_sesssion which is set here

https://github.com/odoo/odoo/blob/439bef710b78afe0e5ba1d54ce04a5e5c3906cdc/addons/mail/models/mail_mail.py#L397

The content of the FROM is replaced by the value on the session here :

https://github.com/odoo/odoo/blob/15aa0e5025e35a5093bd70cae0513cb492806dcc/odoo/addons/base/models/ir_mail_server.py#L602

Do you have this kind of issue ?

@yostashiro

yostashiro commented Feb 14, 2023

Copy link
Copy Markdown
Member

@adrienpeiffer I believe #1051 will fix the issue you mention.

adrienpeiffer
adrienpeiffer suggested changes Feb 24, 2023
View reviewed changes
Comment thread mail_outbound_static/models/ir_mail_server.py Outdated
lasley and others added 24 commits February 25, 2023 12:06
@lasley @dreispt
ADD mail_outbound_static: Allow configuration of from email header
8a323e0 
* Allow for the configuration of the FROM header for outbound emails, and move the existing from header to Sender as per RFC-2822
@eLBati @dreispt
Port mail_outbound_static to 12.0
5aa64c2 
Fixing and extending tests
Add setup
@eLBati @yajo @dreispt
Update website in mail_outbound_static/__manifest__.py
b89b7e1 
Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>
@oca-travis @dreispt
[UPD] Update mail_outbound_static.pot
5a9599a
@OCA-git-bot @dreispt
[UPD] README.rst
127cd49
@BT-fgarbely @dreispt
[MIG] mail_outbound_static: Migration to 13.0
ef8263e
@BT-fgarbely @dreispt
[IMP] mail_outbound_static: black, isort, prettier
2cdbe32
@oca-travis @dreispt
[UPD] Update mail_outbound_static.pot
e96bad6
@OCA-git-bot @dreispt
[UPD] README.rst
2b6b384
@eLBati @dreispt
[FIX] 13.0 mail_outbound_static
c60495a 
use sudo to get ir.config_parameter, otherwise when normal users try to
send email they get AccessError
@OCA-git-bot @dreispt
mail_outbound_static 13.0.1.0.1
cb6ab25
@pierre-pizzetta @dreispt
[MIG] mail_outbound_static: Migration to 14.0
5c0f533
@oca-travis @dreispt
[UPD] Update mail_outbound_static.pot
253e227
@zaoral @dreispt
mail_outbound_static: Domain whitelist based logic.
d83dc8c
@zaoral @dreispt
new changes to squash after review:
66643e9 
- fix misspellings errors in documentation
- add unit test to avoid github checkers red status in codecov tests.
- add validation of email from and domain whitelist fields.
- update documentation remove roadmap for already updated functionalities.
- update translations
@rousseldenis @dreispt
[14.0][FIX] mail_outbound_static: Apply pre-commit
7ee4afd
@yankinmax @dreispt
[IMP] mail_outbound_static: black, isort, prettier
e8f34ab
@yankinmax @dreispt
[MIG] mail_outbound_static: Migration to 15.0
ee4ff7e
@yankinmax @dreispt
[IMP] mail_outbound_static: pylint
d595e0f
@yankinmax @dreispt
fixup! [MIG] mail_outbound_static: Migration to 15.0
5d87c6e
@dreispt
[UPD] Update mail_outbound_static.pot
6e13ffd
@victoralmau @dreispt
[FIX] mail_outbound_static: Remove warning
95fd728
@dreispt
[IMP] mail_outbound_static: pre-commit stuff
81934c6
@dreispt
[MIG] mail_outbound_static: Migration to 16.0
ec06042
@dreispt dreispt force-pushed the 16.0-mig-mail_outbound_static branch 2 times, most recently from 075eb79 to ec06042 Compare February 25, 2023 15:09
@dreispt

dreispt commented Feb 25, 2023

Copy link
Copy Markdown
Member Author

Fixed and rebased.
Please re-review.

@hbrunn

hbrunn commented Mar 20, 2023

Copy link
Copy Markdown
Member

/ocabot merge nopatch
/ocabot migration mail_outbound_static

@OCA-git-bot

OCA-git-bot commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

Hi @hbrunn. Your command failed:

Invalid options for command merge: nopatch.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@hbrunn

hbrunn commented Mar 20, 2023

Copy link
Copy Markdown
Member

/ocabot merge nobump
/ocabot migration mail_outbound_static

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 20, 2023
@OCA-git-bot

OCA-git-bot commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1035-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 20, 2023
Open
40 tasks
@OCA-git-bot OCA-git-bot merged commit dafb7bb into OCA:16.0 Mar 20, 2023
@OCA-git-bot

OCA-git-bot commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at edefc01. Thanks a lot for contributing to OCA. ❤️

SiesslPhillip pushed a commit to grueneerde/OCA-social that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#1035 from OCA/16.0
7a96a61 
Syncing from upstream OCA/social (16.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hbrunn hbrunn hbrunn approved these changes

@adrienpeiffer adrienpeiffer Awaiting requested review from adrienpeiffer

@yostashiro yostashiro Awaiting requested review from yostashiro

+1 more reviewer

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.