Skip to content

[16.0][MIG] mail_template_multi_attachment#1094

Merged
OCA-git-bot merged 6 commits into
OCA:16.0from
sodexis:16.0-mig-mail_template_multi_attachment
May 21, 2024
Merged

[16.0][MIG] mail_template_multi_attachment#1094
OCA-git-bot merged 6 commits into
OCA:16.0from
sodexis:16.0-mig-mail_template_multi_attachment

Conversation

@atchuthan

@atchuthan atchuthan commented Mar 10, 2023

Copy link
Copy Markdown
Member

acsonefho and others added 5 commits March 10, 2023 18:02
@acsonefho @atchuthan
[13.0][ADD] mail_template_multi_attachment
4693d90 
This module allows to add more than 1 attachment (limitation of Odoo standard) to be generated during the email template render. These attachments are sent to the customer with the email's body
@oca-travis @atchuthan
[UPD] Update mail_template_multi_attachment.pot
31963a6
@OCA-git-bot @atchuthan
[UPD] README.rst
b1e2b41
@OCA-git-bot @atchuthan
[ADD] icon.png
8115dcf
@atchuthan
[IMP] mail_template_multi_attachment: pre-commit stuff
fd7ebbc
@atchuthan atchuthan force-pushed the 16.0-mig-mail_template_multi_attachment branch 3 times, most recently from 9adb986 to 0123bcb Compare April 18, 2023 06:58
BT-anieto
BT-anieto approved these changes May 24, 2023
View reviewed changes

@BT-anieto BT-anieto left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BT-anieto

BT-anieto commented May 24, 2023

Copy link
Copy Markdown

@OCA/social-maintainers Could you please add this module to the list of modules?

@wehrend

wehrend commented Aug 15, 2023

Copy link
Copy Markdown

Any info in this module, and why it is not migrated to odoo 15 / odoo 16 ?
Please give me some hint.

@simahawk

simahawk commented Aug 16, 2023

Copy link
Copy Markdown

/ocabot migration mail_template_multi_attachment

@simahawk

simahawk commented Aug 16, 2023

Copy link
Copy Markdown

Any info in this module, and why it is not migrated to odoo 15 / odoo 16 ? Please give me some hint.

It was not in the v16 mig list because it was not in v15 when the 16.0 branch was created.
Is not in v15 because nobody migrated it. Feel free to do it if you need it 😉

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 16, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 16, 2023
Open
40 tasks
@wehrend

wehrend commented Aug 16, 2023 via email

Copy link
Copy Markdown

@simahawk

simahawk commented Aug 17, 2023 •
edited
Loading

Copy link
Copy Markdown

I've forked the repo, and made some changes, then I've commited them. 9ecdc03 How can I now ask for a pull request and put it into OCA/social ?

Sorry, I don't understand your question. What are you trying to achieve?
If you are trying to add a change to this PR you should open it against the fork of @atchuthan and ask him if he could integrate it here.

simahawk
simahawk reviewed Aug 17, 2023
View reviewed changes
Comment thread mail_template_multi_attachment/models/mail_template.py
ghost
ghost suggested changes Dec 1, 2023
View reviewed changes
Comment thread mail_template_multi_attachment/models/mail_template.py Outdated
@legalsylvain

legalsylvain commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

hi @atchuthan. Thanks for porting this module. Could you take a look on the @jdidderen-noviat remark, and ideally add tests ?

thanks !

@github-actions

github-actions Bot commented Apr 21, 2024

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 21, 2024
@legalsylvain

legalsylvain commented Apr 21, 2024

Copy link
Copy Markdown
Contributor

hi @atchuthan . will you finish this PR ? thanks !

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024
@SodexisTeam SodexisTeam force-pushed the 16.0-mig-mail_template_multi_attachment branch from 0123bcb to 0db50e6 Compare May 20, 2024 07:11
@SodexisTeam SodexisTeam force-pushed the 16.0-mig-mail_template_multi_attachment branch from 0db50e6 to ddb0724 Compare May 20, 2024 07:37
@atchuthan

atchuthan commented May 20, 2024

Copy link
Copy Markdown
Member Author

hi @atchuthan . will you finish this PR ? thanks !

@legalsylvain sorry for the late reply. Above changes requested are done in the latest changes. Please check and let us know.

legalsylvain
legalsylvain reviewed May 20, 2024
View reviewed changes

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. code review / no test.

thanks for porting this module !

@legalsylvain

legalsylvain commented May 20, 2024

Copy link
Copy Markdown
Contributor

@jdidderen-noviat : Could you update your review ?

@acsonefho : FYI.

ghost
ghost approved these changes May 20, 2024
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

acsonefho
acsonefho approved these changes May 21, 2024
View reviewed changes

@acsonefho acsonefho left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only; no test

@atchuthan

atchuthan commented May 21, 2024

Copy link
Copy Markdown
Member Author

@OCA/social-maintainers could we merge this PR?

@simahawk

simahawk commented May 21, 2024

Copy link
Copy Markdown

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented May 21, 2024

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1094-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 31b7227 into OCA:16.0 May 21, 2024
@OCA-git-bot

OCA-git-bot commented May 21, 2024

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 3c2b8e3. Thanks a lot for contributing to OCA. ❤️

SiesslPhillip pushed a commit to grueneerde/OCA-social that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#1094 from OCA/15.0
a52ac0b 
Syncing from upstream OCA/social (15.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk left review comments

+5 more reviewers

@legalsylvain legalsylvain legalsylvain left review comments

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

@acsonefho acsonefho acsonefho approved these changes

@BT-anieto BT-anieto BT-anieto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

10 participants

@atchuthan @BT-anieto @wehrend @simahawk @legalsylvain @OCA-git-bot @ThomasBinsfeld @acsonefho @oca-travis @SodexisTeam