Skip to content

[16.0][MIG] mail_activity_team: Migration to 16.0#1129

Merged
OCA-git-bot merged 72 commits into
OCA:16.0from
rven:16.0-mig-mail_activity_team
Jun 8, 2023
Merged

[16.0][MIG] mail_activity_team: Migration to 16.0#1129
OCA-git-bot merged 72 commits into
OCA:16.0from
rven:16.0-mig-mail_activity_team

Conversation

@rven

@rven rven commented Apr 17, 2023

Copy link
Copy Markdown

No description provided.

JordiBForgeFlow and others added 30 commits April 17, 2023 12:43
Currently translated at 100.0% (24 of 24 strings)

Translation: social-13.0/social-13.0-mail_activity_team
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_team/it/
When an activity is scheduled due to automatic processes the onchanges
won't adapt the proper user team, so we could have a mismatch that
provokes an exceptions due to the designed constaints
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-13.0/social-13.0-mail_activity_team
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_team/
- If a user is archived but there's an automatic activity, the team
check wouldn't locate him. We have to ensure the context.
- When the automatic activity gets a user with no team, we should set
the team to a void one as well.

TT30470
Currently translated at 32.0% (8 of 25 strings)

Translation: social-13.0/social-13.0-mail_activity_team
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_team/fr/
OCA-git-bot and others added 5 commits April 17, 2023 12:43
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-15.0/social-15.0-mail_activity_team
Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_activity_team/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-15.0/social-15.0-mail_activity_team
Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_activity_team/
@rven rven mentioned this pull request Apr 17, 2023
40 tasks
@rven rven marked this pull request as draft April 18, 2023 11:27
@rven rven force-pushed the 16.0-mig-mail_activity_team branch 2 times, most recently from 75b7594 to b8038ef Compare April 19, 2023 08:27
@rven rven marked this pull request as ready for review April 19, 2023 08:57

@bealdav bealdav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution.

image

Module works, but when a team is notified, concerned users are not warn as it happens with individual alert
No indicator displayed

I don't know if it's intentional !?
@JordiBForgeFlow @MiquelRForgeFlow

@@ -23,13 +23,27 @@ def _search_my_activity_date_deadline(self, operator, operand):
return super(MailActivityMixin, self)._search_my_activity_date_deadline(

This comment was marked as outdated.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bealdav Can this be reproduced in an earlier version?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the activities pop-up is "closed", it always shows My Activities.
It only temporarily shows the Team Activities when you select it in the pop-up.
It was designed like this so I also left this like it was.

Comment thread mail_activity_team/models/mail_activity.py Outdated
Comment thread mail_activity_team/models/mail_activity_mixin.py Outdated
@rven rven force-pushed the 16.0-mig-mail_activity_team branch from b8038ef to 6e67f2d Compare April 25, 2023 08:04
@rven rven requested a review from bealdav April 25, 2023 08:06
@rven rven force-pushed the 16.0-mig-mail_activity_team branch from 6e67f2d to e30c539 Compare April 25, 2023 08:07
@rven rven force-pushed the 16.0-mig-mail_activity_team branch from e30c539 to 0b8446e Compare April 25, 2023 08:07

@bealdav bealdav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LGTM to me

Needs experts on this module to a more appropriate approval

@Bert038

Bert038 commented Jun 8, 2023

Copy link
Copy Markdown

Can this being merged to v16? The percentage of code check is negligible :)

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration mail_activity_team
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 8, 2023
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1129-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f97cacd into OCA:16.0 Jun 8, 2023
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c6180dd. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.