Skip to content

[16.0][MIG] mail_show_follower#1132

Merged
OCA-git-bot merged 21 commits into
OCA:16.0from
bosd:16.0-mig-mail_show_follower
Sep 22, 2023
Merged

[16.0][MIG] mail_show_follower#1132
OCA-git-bot merged 21 commits into
OCA:16.0from
bosd:16.0-mig-mail_show_follower

Conversation

@bosd

@bosd bosd commented Apr 20, 2023

Copy link
Copy Markdown

standard migration

@bosd bosd marked this pull request as ready for review April 20, 2023 12:15
@bosd bosd mentioned this pull request Apr 20, 2023
Open
40 tasks
@rafaelbn

rafaelbn commented Jun 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

/ocabot migration mail_show_follower

Nota: This module has bugs in previous versions not solved.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 3, 2023
@bosd

bosd commented Jun 23, 2023

Copy link
Copy Markdown
Author

Nota: This module has bugs in previous versions not solved.

You have a link to the issue?
Should this pr be converted to draft?

@cliffkujala

cliffkujala commented Jul 6, 2023

Copy link
Copy Markdown

I am willing to sponsor this to help get it merged to v16.

@EmilioPascual

EmilioPascual commented Sep 19, 2023

Copy link
Copy Markdown

@bosd can you make rebase? Runboat isn't run, with rebase it must run.

@EmilioPascual

EmilioPascual commented Sep 19, 2023

Copy link
Copy Markdown

Nota: This module has bugs in previous versions not solved.

You have a link to the issue? Should this pr be converted to draft?

Issue: #970
However, this issue should not stop this migration.

ValentinVinagre and others added 21 commits September 21, 2023 07:53
@ValentinVinagre @bosd
ADD mail_show_follower copied from https://github.com/sygel-technolog…
e26b82e 
…y/sy-server-backend/tree/12.0/mail_show_follower
@eLBati @bosd
IMP mail_show_follower metadata and style
5b4b12e 
Display CC according to notification_type
@oca-travis @bosd
[UPD] Update mail_show_follower.pot
e3a25f2
@OCA-git-bot @bosd
[UPD] README.rst
9c4f699
@OCA-git-bot @bosd
[ADD] icon.png
27a2472
@ypapouin @bosd
Translated using Weblate (French)
aec1241 
Currently translated at 100.0% (7 of 7 strings)

Translation: social-12.0/social-12.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_show_follower/fr/
@eLBati @bosd
FIX mail_show_follower: ValueError: Expected singleton: res.users
de9b0fc
@rafaelbn @bosd
[12.0][mail_show_follower] Update version
30eb91c 
As commented in OCA#788 the PR should be merged manually but we should update the version of the module as a minor update

cc @ValentinVinagre @eLBati @MiquelRForgeFlow @HaraldPanten
@rafaelbn @MiquelRForgeFlow @bosd
Update mail_show_follower/__manifest__.py
74f587f 
Co-authored-by: Miquel Raïch <miquel.raich@eficent.com>
@Shide @bosd
[IMP] mail_show_follower: black, isort, prettier
19a7014
@Shide @bosd
[MIG] mail_show_follower: Migration to 15.0
6fe60c5 
[REF] Compact comment
@bosd
[UPD] Update mail_show_follower.pot
fcde0aa
@Shide @bosd
[ADD] Customize notification appearance
cd1ca9c 
Added settings to customize notification and translations to important parts of the message.

[FIX] Security fixes and simplified customization

Field `show_followers_partner_format` formatted with %(param)s
Removed CSS customizations

[FIX] README options

[FIX] Index.html configure

[FIX] Several changes

- Removed unnecesary properties on res_config_settings
- Markup safe on partner_format
- Use email_domain_extract instead own one
@OCA-git-bot @bosd
mail_show_follower 15.0.1.2.0
e609c74
@Shide @bosd
[FIX] Add recipients of the all related messages on the notification
b4a223a 
When using composer, doesn't include all recipients of the message on the notification.
@OCA-git-bot @bosd
mail_show_follower 15.0.1.2.1
86a2089
@yajo @bosd
[FIX] mail_show_follower: failure when partner has more than 1 user
fa29d05 
In the highly improbable but actually possible and real world case that a partner has more than one user associated, this change makes the emails able to send.

@moduon MT-1634
@yajo @bosd
[BUILD] mail_show_follower: adopt module
55075f5
@OCA-git-bot @bosd
mail_show_follower 15.0.1.2.2
ba4fce5
@bosd
[IMP] mail_show_follower: pre-commit execution
17e5faf
@bosd
[MIG] mail_show_follower: Migration to 16.0
99696d1
@bosd bosd force-pushed the 16.0-mig-mail_show_follower branch from 69c8b19 to 99696d1 Compare September 21, 2023 05:54
@bosd

bosd commented Sep 21, 2023

Copy link
Copy Markdown
Author

@bosd can you make rebase? Runboat isn't run, with rebase it must run.

Done 😄

EmilioPascual
EmilioPascual approved these changes Sep 21, 2023
View reviewed changes

@EmilioPascual EmilioPascual left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosd

bosd commented Sep 21, 2023

Copy link
Copy Markdown
Author

I am willing to sponsor this to help get it merged to v16.

@cliffkujala No sponsorship needed for now. But you could help leaving a review.

yajo
yajo approved these changes Sep 22, 2023
View reviewed changes

@yajo yajo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & functional review

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1132-by-yajo-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e6e9446 into OCA:16.0 Sep 22, 2023
@OCA-git-bot

OCA-git-bot commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f764894. Thanks a lot for contributing to OCA. ❤️

@bosd

bosd commented Sep 22, 2023

Copy link
Copy Markdown
Author

@CasVissers-360ERP

CC: @espo-tony
It's Done

@bosd bosd deleted the 16.0-mig-mail_show_follower branch September 22, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yajo yajo yajo approved these changes

+1 more reviewer

@EmilioPascual EmilioPascual EmilioPascual approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.