[16.0][MIG] mail_embed_image#1873
Open
PicchiSeba wants to merge 20 commits into
Open
Conversation
- CIDs are not working in some email managers (gmail and office365) To allow this behavior we need to change the content type to multipart/related and reorganize the parts (see comments in code) - A new option to embed images is to include the base64 content inside the src. - Then to select these options, a selected field has been added to company
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superesedes #1499
Thir PR aims to migrate the
mail_embed_imagemodule to version16.0.I based this PR on an earlier PR that was stale and closed, preserving commit ownership.
I tested in a dev environment and it seems to behave as expected. Let me know if there are are changes to make or testing scenarios to check.