Skip to content

[16.0][MIG-REF] storage_import_image_advanced -> fs_import_image_advanced, fs_import_image_advanced_thumbnail #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ChrisOForgeFlow wants to merge 30 commits into from
Closed

[16.0][MIG-REF] storage_import_image_advanced -> fs_import_image_advanced, fs_import_image_advanced_thumbnail #360

ChrisOForgeFlow wants to merge 30 commits into from

Conversation

@ChrisOForgeFlow
Copy link

@ChrisOForgeFlow ChrisOForgeFlow commented Apr 16, 2024 •
edited
Loading

  • Refactor from storage_import_image_advanced
  • Change to use fs_storage and fs_product_multi_image as dependencies
  • Fix test to use properly test class dependency
  • Removed storage_id field, setup of model or fields is unique way to address fs in new model
  • Removed thumbnail support, because module is not required by module fs_product_multi_image, added a new glue module 'fs_import_image_advanced_thumbnail' support to create automatic thumbnails when module fs_image_thumbnail is installed

HviorForgeFlow and others added 28 commits April 15, 2024 12:15
@HviorForgeFlow @ChrisOForgeFlow
[13.0][ADD] storage_import_image_advanced: Drop shopinvader dependenc…
d88d076 
…ies + rename from shopinvader_import_image
@HviorForgeFlow @ChrisOForgeFlow
Adapt tests
24b8705
@HviorForgeFlow @ChrisOForgeFlow
[IMP] storage_import_image_advanced: black, isort, prettier
ac49aff
@JordiBForgeFlow @ChrisOForgeFlow
[storage_import_image_advanced][imp] make the choice of the product i…
5357198 
…dentifier more flexible
@ivantodorovich @ChrisOForgeFlow
[IMP] storage_import_image_advanced: action buttons should be in header
16b7829
@ivantodorovich @ChrisOForgeFlow
[FIX] storage_import_image_advanced: Missing filename field
e54d2af
@ivantodorovich @ChrisOForgeFlow
[IMP] storage_image_import_advanced: Allow to configure the csv colum…
439000d 
…n mapping
@HviorForgeFlow @ChrisOForgeFlow
[IMP] storage_import_image_advanced: black, isort, prettier
cee9a4b
@HviorForgeFlow @ChrisOForgeFlow
[FIX] Recompute thumbs explicitly
57d8c4f
@HviorForgeFlow @ChrisOForgeFlow
[FIX] Zip Filename display
334af06
@oca-travis @ChrisOForgeFlow
[UPD] README.rst
7b5f46b
@OCA-git-bot @ChrisOForgeFlow
storage_import_image_advanced 13.0.1.0.1
4a68db5
@HviorForgeFlow @ChrisOForgeFlow
[FIX] tmpl report_html reference
982f2ab
@OCA-git-bot @ChrisOForgeFlow
storage_import_image_advanced 13.0.1.0.2
4b58065
@i-vyshnevska @ChrisOForgeFlow
[MIG][14.0] storage_import_image_advanced
204e1ae
@i-vyshnevska @ChrisOForgeFlow
[IMP] storage_import_image_advanced
c23482a
@oca-travis @ChrisOForgeFlow
[UPD] Update storage_import_image_advanced.pot
824339e
@OCA-git-bot @ChrisOForgeFlow
[UPD] README.rst
ffb5e88
@OCA-git-bot @ChrisOForgeFlow
storage_import_image_advanced 14.0.1.0.1
aa0dc17
@simahawk @ChrisOForgeFlow
storage_import_image_advanced: fix report render
8304615
@OCA-git-bot @ChrisOForgeFlow
storage_import_image_advanced 14.0.1.0.2
2b9329b
@HviorForgeFlow @ChrisOForgeFlow
[IMP] storage_import_image_advanced: Add hook
74cad90
@JasminSForgeFlow @ChrisOForgeFlow
[IMP] storage_import_image_advanced: black, isort, prettier
ca94504
@JasminSForgeFlow @ChrisOForgeFlow
[MIG] storage_import_image_advanced: Migration to 15.0
9d04c55
@ChrisOForgeFlow
[UPD] Update storage_import_image_advanced.pot
2004fd0
@OCA-git-bot @ChrisOForgeFlow
[UPD] README.rst
bd392f2
@OCA-git-bot @ChrisOForgeFlow
[UPD] README.rst
f756b22
@ChrisOForgeFlow
[IMP] storage_import_image_advanced: : pre-commit stuff
5fa49db
@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 16.0-mig-storage_import_image_advanced branch from 6dd56e7 to 0812682 Compare April 16, 2024 12:36
@ChrisOForgeFlow
[16.0][MIG-REF] fs_import_image_advanced
0ccbfe6 
- Refactor from storage_import_image_advanced
- Change to user fs_storage and fs_product_multi_image as dependencies
- Fix test to use properly test class dependency
@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 16.0-mig-storage_import_image_advanced branch from 0812682 to 0ccbfe6 Compare April 17, 2024 16:45
@ChrisOForgeFlow ChrisOForgeFlow changed the title [16.0][MIG-REF] storage_import_image_advanced -> fs_import_image_advanced [16.0][MIG-REF] storage_import_image_advanced -> fs_import_image_advanced, fs_import_image_advanced_thumbnail Apr 22, 2024
@ChrisOForgeFlow ChrisOForgeFlow marked this pull request as ready for review April 22, 2024 16:39
@github-actions
Copy link

github-actions bot commented Aug 25, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 25, 2024
@github-actions github-actions bot closed this Sep 29, 2024
@AlexPForgeFlow
Copy link

AlexPForgeFlow commented Mar 14, 2025

can we reopen?

@xaviedoanhduy xaviedoanhduy mentioned this pull request Apr 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@ChrisOForgeFlow @AlexPForgeFlow @HviorForgeFlow @JordiBForgeFlow @ivantodorovich @oca-travis @OCA-git-bot @i-vyshnevska @simahawk @JasminSForgeFlow