[11.0][web_widget_x2many_matrix] fix issue with limit of records

[JordiBForgeFlow]

Fixes #1012

[JordiBForgeFlow]

Thanks to @tonihr for proposing the fix!

cc @agranadosb, @simahawk @pedrobaeza

As you can see below, I can now generate huge many2many_matrix grids.

[pedrobaeza]

Why a new file instead existing ones?

[pedrobaeza]

Check syntax recommendations from https://travis-ci.org/OCA/web/jobs/413220985#L844

[JordiBForgeFlow]

@pedrobaeza We create a new file so it is easier to understand that we are changing a different class.
@simahawk I have also applied the proper indentations.

[simahawk]

I'm fine w/ the new file BTW :)

[pedrobaeza]

Let's not introduce new JS lint warnings:

web_widget_x2many_2d_matrix/static/src/js/abstract_view_matrix_limit_extend.js:10: [W7903(javascript-lint), ] Unexpected tab character. [Error/no-tabs]
web_widget_x2many_2d_matrix/static/src/js/abstract_view_matrix_limit_extend.js:10: [W7903(javascript-lint), ] Mixed spaces and tabs. [Error/no-mixed-spaces-and-tabs]
web_widget_x2many_2d_matrix/static/src/js/abstract_view_matrix_limit_extend.js:12: [W7903(javascript-lint), ] Missing radix parameter. [Error/radix]
web_widget_x2many_2d_matrix/static/src/js/abstract_view_matrix_limit_extend.js:10: [W7910(wrong-tabs-instead-of-spaces), ]  Use wrong tabs indentation instead of four spaces

[JordiBForgeFlow]

@pedrobaeza I'm not sure where you found the warnings, but I attended them.

[pedrobaeza]

You have introduced even more warnings. You can see them on https://travis-ci.org/OCA/web/jobs/423957411#L2131

[simahawk]

@jbeficent can you get back to this? :)

[pedrobaeza]

@jbeficent I have faced this issue today. Are you going to finish this?

[JordiBForgeFlow]

@pedrobaeza let me finish it now

[pedrobaeza]

@tarteo @yajo @simahawk can you re-review?

[JordiBForgeFlow]

@tarteo @pedrobaeza I have no idea how to fix the lint errors. I have tried to fix, but I cannot resolve. Any idea?

[tarteo]

Try it like this:

odoo.define(
    "web_widget_x2many_2d_matrix.matrix_limit_extend",
    function (require) {
        "use strict";

        var AbstractView = require("web.AbstractView");

        AbstractView.include({
        ...
     }
);

[yajo]

Actually there's an exception on the line width for the odoo.define lines in the linter, just for the case you have at hand.

The best you can do here is to put just a single line:

 odoo.define( "web_widget_x2many_2d_matrix.matrix_limit_extend", function (require) {

Thanks to that exception, the linter should be OK.

[tarteo]

You're missing here );

[JordiBForgeFlow]

We're good to go

[pedrobaeza]

There were a syntax error fixed here: 899f01f

[hhgabelgaard]

@jbeficent In Google Chrome this fails with an Uncaught SyntaxError: missing ) after argument list in line 15

Changing to below seems to work:

                    attrs.limit = Infinity;
                }
            },
        });
    }
);

But I'm no javascript expert!

[pedrobaeza]

@hhgabelgaard I have just written the same and fixed it on the fly. Just update...

[hhgabelgaard]

@pedrobaeza Thanks!