Skip to content

[11.0][IMP] Total of all rows in web_widget_x2many_2d_matrix#1043

Merged
pedrobaeza merged 2 commits into
OCA:11.0from
tarteo:11-matrix-total
Sep 20, 2018
Merged

[11.0][IMP] Total of all rows in web_widget_x2many_2d_matrix#1043
pedrobaeza merged 2 commits into
OCA:11.0from
tarteo:11-matrix-total

Conversation

@tarteo

@tarteo tarteo commented Sep 20, 2018

Copy link
Copy Markdown
Member

This PR will add a cell to the right corner with the total of all the columns / rows.

image

@astirpe astirpe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using this improvement in production (with module hr_timesheet_sheet) and it works fine.

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking, otherwise LGTM:

  1. docstring missing
  2. can you update the screenshot in README?

}
},

_renderTotalCell: function() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring pls :)

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pedrobaeza pedrobaeza merged commit 4fea08d into OCA:11.0 Sep 20, 2018
alexey-pelykh pushed a commit to brainbeanapps/web that referenced this pull request Nov 9, 2018
alexey-pelykh pushed a commit to brainbeanapps/web that referenced this pull request Nov 9, 2018
@tarteo tarteo deleted the 11-matrix-total branch November 26, 2019 08:27
AdriaGForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Jan 10, 2020
AdriaGForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Feb 14, 2020
AdriaGForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Mar 5, 2020
Saran440 pushed a commit to ecosoft-odoo/web that referenced this pull request Nov 13, 2020
Saran440 pushed a commit to ecosoft-odoo/web that referenced this pull request Nov 13, 2020
pniederlag pushed a commit to datenbetrieb/web that referenced this pull request Dec 26, 2020
ChrisOForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Dec 13, 2021
LoisRForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Feb 18, 2022
bizzappdev pushed a commit to bizzappdev/web that referenced this pull request Nov 5, 2022
JoanSForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Nov 14, 2022
tarteo added a commit to tarteo/web that referenced this pull request Feb 28, 2023
dreispt pushed a commit to ursais/web that referenced this pull request Jan 21, 2024
norlinhenrik pushed a commit to norlinhenrik/oca-web that referenced this pull request Jan 28, 2024
SodexisTeam pushed a commit to SodexisTeam/web that referenced this pull request Feb 29, 2024
mohs8421 pushed a commit to mohs8421/oca-web that referenced this pull request Jun 18, 2024
Borruso pushed a commit to Borruso/web that referenced this pull request Nov 26, 2024
yankinmax pushed a commit to yankinmax/web that referenced this pull request Jan 7, 2025
sebalix pushed a commit to camptocamp/web that referenced this pull request Jan 22, 2025
natuan9 pushed a commit to camptocamp/web that referenced this pull request Feb 3, 2025
yankinmax pushed a commit to yankinmax/web that referenced this pull request Mar 6, 2025
bizzappdev pushed a commit to BizzAppDev-Systems/web that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants