Skip to content

[18.0][MIG] web_copy_confirm: Migration to 18.0#3242

Merged
OCA-git-bot merged 20 commits into
OCA:18.0from
ForgeFlow:18.0-mig-web_copy_confirm
Aug 18, 2025
Merged

[18.0][MIG] web_copy_confirm: Migration to 18.0#3242
OCA-git-bot merged 20 commits into
OCA:18.0from
ForgeFlow:18.0-mig-web_copy_confirm

Conversation

@ArnauCForgeFlow

Copy link
Copy Markdown
Contributor

Standard Migration to v18.0

StefanRijnhart and others added 19 commits August 6, 2025 15:52
[UPD] Update web_copy_confirm.pot

[ADD] icon.png
Currently translated at 100.0% (2 of 2 strings)

Translation: web-14.0/web-14.0-web_copy_confirm
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_copy_confirm/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_copy_confirm
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_copy_confirm/
Currently translated at 100.0% (2 of 2 strings)

Translation: web-16.0/web-16.0-web_copy_confirm
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_copy_confirm/it/
Currently translated at 100.0% (2 of 2 strings)

Translation: web-16.0/web-16.0-web_copy_confirm
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_copy_confirm/fr/
@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-web_copy_confirm branch from 45f3f74 to 7af483e Compare August 7, 2025 09:11

@LoisRForgeFlow LoisRForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I works good from form view. However, now it is also possible to duplicate from the list view:
image

I think it should be covered too.

@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-web_copy_confirm branch from 7af483e to f3d3858 Compare August 7, 2025 14:30
@ArnauCForgeFlow

Copy link
Copy Markdown
Contributor Author

Done, now the pop-up appears aswell in the list view.

@LoisRForgeFlow LoisRForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Tested and works as expected 👍

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM!

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow

Copy link
Copy Markdown
Contributor

@OCA/web-maintainers could you merge?

@CarlosRoca13 CarlosRoca13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 comments

Comment thread web_copy_confirm/static/tests/confirm.test.js
Comment thread web_copy_confirm/static/src/js/web_copy_confirm.esm.js Outdated
@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-web_copy_confirm branch from f3d3858 to 0da880a Compare August 18, 2025 08:48

@CarlosRoca13 CarlosRoca13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration web_copy_confirm
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 18, 2025
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3242-by-CarlosRoca13-bump-nobump, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 3669255. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 944a6c7 into OCA:18.0 Aug 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.