Skip to content

[18.0][MIG] web_select_all_companies: Migration to 18.0#3340

Open
natuan9 wants to merge 10 commits into
OCA:18.0from
natuan9:18.0-mig-web_select_all_companies
Open

[18.0][MIG] web_select_all_companies: Migration to 18.0#3340
natuan9 wants to merge 10 commits into
OCA:18.0from
natuan9:18.0-mig-web_select_all_companies

Conversation

@natuan9

@natuan9 natuan9 commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Changes

  • The "Select All Companies" feature was added in version 18.0 (from this commit). The "Select All" checkbox is displayed when there are 10 or more companies. In MIG commit, I customized it so that the "Select All" checkbox is displayed when there is more than one company.
  • Added default_company_ids field to res.users that will control which companies are selected by default

DorianMAG
DorianMAG approved these changes Oct 23, 2025
View reviewed changes

@DorianMAG DorianMAG left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the migration.
Functional test on runboat.
LGTM

JulienMartinez
JulienMartinez approved these changes Oct 23, 2025
View reviewed changes

@JulienMartinez JulienMartinez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test on runboat.
LGTM
thx

flotho
flotho approved these changes Oct 23, 2025
View reviewed changes

@flotho flotho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks,
successfully tested on runboat

@OCA-git-bot

OCA-git-bot commented Oct 26, 2025

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@natuan9 natuan9 force-pushed the 18.0-mig-web_select_all_companies branch from 7fbb070 to c7497f3 Compare October 27, 2025 03:57
@natuan9

natuan9 commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

Hi, thanks for your review! I've just made a small change.
Most users don't have access to the res.user form, so we also need to display default_company_ids field in the Preferences form.

@ivs-cetmix

ivs-cetmix commented Dec 22, 2025

Copy link
Copy Markdown
Member

Hey @natuan9 could you please squash the administrative commits (the ones with the [UPD].. tag) if you are comfortable with it?
@flotho could you please check if the recent change is working fine?

@natuan9 natuan9 force-pushed the 18.0-mig-web_select_all_companies branch from c7497f3 to 4840b6f Compare December 23, 2025 03:08
@tarteo

tarteo commented Apr 16, 2026

Copy link
Copy Markdown
Member

/ocabot migration web_select_all_companies

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Apr 16, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 16, 2026
Open
49 tasks
tarteo
tarteo reviewed Apr 16, 2026
View reviewed changes

@tarteo tarteo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should remove translation files, I couldn't test it on Runboat, but as 3 people already reviewed I assume it's okay!

Comment thread web_select_all_companies/readme/DESCRIPTION.md
This module allows you to select or deselect all the companies in a
single click.

![image](./static/description/select_all_companies.png)

@tarteo tarteo Apr 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't exist

Comment thread web_select_all_companies/readme/DESCRIPTION.md

@tarteo tarteo Apr 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to add your videos here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarteo tarteo tarteo left review comments
+3 more reviewers
@flotho flotho flotho approved these changes
@JulienMartinez JulienMartinez JulienMartinez approved these changes
@DorianMAG DorianMAG DorianMAG approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.