Ldvars separation #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three hundred lines!
Only 250 lines versus entry values!
350 lines ish, much more like it.
This makes the code much less ugly (but still ugly). I feel vaguely good about it. It's still much longer than I originally intended; but here we are.
So there's no point going through this add/remove rigmarole.
This is more difficult than it looks, due to the amount of code that I wrote that assumes that a register number is a machine location. To fix that, add a stronger integer type to identify a machine location, the location index. (tests currently fail).
Which keeps disappearing in debug mode?
This is so that we can track them for now, in the temporary absence of mphis
Just have a big bloody table instead.
Instead, def what's already def'd, and store the regmask for later use. I suspect it's not valid to read something that's only written by a regmask, but lets be conservative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this Pull Request so that it's easy to browse these changes!