problem with $apply and $orderby

[MolallaComm]

It appears the group by issues discussed in #76 are partially fixed using efcore6, .net core 6, and latest odata which is good news. If I do just a simple group by:

/odata/Item?$apply=groupby((ComponentID),aggregate($count%20as%20GroupCount))&$count=true

it works. If I tack an $orderby on the end however, it stops working:

/odata/Item?$apply=groupby((ComponentID),aggregate($count%20as%20GroupCount))&$count=true&$orderby=ComponentID

Yields:

The query specified in the URI is not valid. The given model does not contain the type 'Microsoft.AspNetCore.OData.Query.Wrapper.AggregationWrapper'

I can see on line 54 of QueryBinderContext.cs where it is looking for that AggregationWrapper in my model, and it obviously isn't there. If I comment that out, it gets further, but then pukes with:

Instance property 'ComponentID' is not defined for type 'Microsoft.AspNetCore.OData.Query.Wrapper.AggregationWrapper'

It seems like the basic expression processing is smart enough to deal with AggregationWrapper, but the orderby expression processing code is not. This worked in 3.1 as long as your controller pulled everything into memory first using something like:

            if (Request.QueryString.Value != null && Request.QueryString.Value.Contains("$apply"))
                return db.Item.ToList().AsQueryable();
            else
                return db.Item;

That fix no longer works in latest however which has me bummed as we use $apply with $orderby a lot.

[xuzhg]

@MolallaComm Thanks for reporting this.

For the query binding refactor, we just finished query except for $apply.for $apply, it's in #400

[MolallaComm]

FWIW, I tried running:

http://localhost:64771/Products?$apply=groupby((Category),aggregate($count%20as%20GroupCount))&$count=true&$orderby=Category

against #400 from KenitoInc’s repo and still get the error:

The query specified in the URI is not valid. The given model does not contain the type 'Microsoft.AspNetCore.OData.Query.Wrapper.AggregationWrapper'.

So it doesn't appear to fully address the issue unfortunately.

[henning-krause]

I've run into the same issue today.

[henning-krause]

I'd like to contribute to this work item because we really need this fixed :-). I looked through the code yesterday, and this seems to be non-trivial. If someone from the Odata team can point me in the right direction I'm happy to help.

[eyeseesharp1]

I'm in the same boat as the above user; really need it fixed and would like to contribute. I started debugging the code locally and got some clues as to what's happening but am not sure as to what the best way to fix it is.

1. The exception thrown from inside the QueryBinderContext constructor is because the code assumes that the clrType param passed in will be an edm type. This isn't the case when the type is a GroupBy/Aggregation wrapper. I've added a check that skips the call to Model.GetEdmTypeReference(ElementClrType) if if typeof(IEdmObject).IsAssignableFrom(ElementClrType) is not true. This is just a symptom of the actual problem.
2. The logic in OrderByQueryOption.cs seems to be the failing point. All OrderBy property nodes remain unchanged after the group by transformation and the single property access fails on type AggregateExpressionWrapper. I'm guessing we need to reconstruct the order by clause before we get here to access the "Item" property of the underlying dictionary instead.

[StacyCMay]

Registering a comment just to amplify this issue. I am getting this error using OData v8.0.6/EF Core 6.0.1/.NET Core 6.0.1.

[eyeseesharp1]

The issue still has not been resolved as of 1/29. Using AspNetCoreOData v8.0.6/EF Core 6.0.1/.NET Core 6.0.1

[padhumailin]

I get the same error when $apply and $top are given

The query specified in the URI is not valid. The given model does not contain the type 'Microsoft.AspNetCore.OData.Query.Wrapper.AggregationWrapper'

Net 6
EF 6
OData 8.0.4

[JawzoD3TH]

.Net 6
EF 6
OData 8.0.7

Test Queries:
?$apply=groupby((Name))
?$apply=groupby((Name),aggregate($count as COUNT))

I have API Controllers & ODataControllers both result in this error.

[TimFeldmann-Work]

In the same boat as everyone else. I want to add the same exact error occurs when adding $order OR $top. I did find that you need to return IQueryable directly for the aggregate to work without $order or $top. If you return an ActionResult<IQueryable> then the aggregate will not work at all.