Skip to content

ASP.NET Core OData should have its own DefaultQuerySettings #834

@xuzhg

Description

@xuzhg

Describe the bug
So far, we are using the 'DefaultQuerySettings' from the Model builder. https://github.com/OData/ModelBuilder/blob/c5cd1ed8b41a7425a1a74766c2e5d8ba24870a2a/src/Microsoft.OData.ModelBuilder/Config/DefaultQuerySettings.cs

we use it here: https://github.com/OData/AspNetCoreOData/blob/main/src/Microsoft.AspNetCore.OData/ODataOptions.cs#L292

I think it's a mistake. Basically, we should create ASP.NET Core OData own 'DefaultQuerySettings', maybe use different name.

Benefit:

  1. loose coupling.
  2. Most important, we can add more configuration items into settings. for example $compute, $search, etc. But all of these are not required at model builder side.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions